Closed
Bug 861601
Opened 11 years ago
Closed 11 years ago
Suppress gcc -Wmultichar warnings from Android's Stagefright header files
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
918 bytes,
patch
|
cajbir
:
review+
khuey
:
review+
|
Details | Diff | Splinter Review |
Firefox for Android has more -Wmultichar warnings than any other warning type. All 185 of these warnings come from Android's Stagefright header files, which use multichar enum values, e.g. enum { kKeyMIMEType = 'mime' } media/omx-plugin/include/froyo/stagefright/MetaData.h:32:20 [-Wmultichar] multi-character character constant ... Q: Should this media makefile change be reviewed by a build peer?
Attachment #737215 -
Flags: review?(chris.double)
Comment 1•11 years ago
|
||
Comment on attachment 737215 [details] [diff] [review] suppress-Wmultichar-warnings.patch Review of attachment 737215 [details] [diff] [review]: ----------------------------------------------------------------- I don't know if it needs a build peer but it looks good to me.
Attachment #737215 -
Flags: review?(chris.double) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 737215 [details] [diff] [review] suppress-Wmultichar-warnings.patch khuey: Do I need a build peer to r+ this Makefile.in change?
Attachment #737215 -
Flags: review?(khuey)
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 737215 [details] [diff] [review] suppress-Wmultichar-warnings.patch r? for makefile change
Attachment #737215 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/52fa74fb7b0f
status-firefox22:
--- → wontfix
status-firefox23:
--- → fixed
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/52fa74fb7b0f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•