Closed
Bug 861605
Opened 11 years ago
Closed 11 years ago
Make the arguments to Window.alert, Window.confirm optional
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: Ms2ger, Assigned: baku)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 3 obsolete files)
|
4.57 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
http://html5.org/tools/web-apps-tracker?from=7831&to=7832 https://www.w3.org/Bugs/Public/show_bug.cgi?id=21587
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #742363 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → amarchesini
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #742363 -
Attachment is obsolete: true
Attachment #742363 -
Flags: review?(Ms2ger)
Attachment #742387 -
Flags: review?(Ms2ger)
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=254a1c0be923
Attachment #742387 -
Attachment is obsolete: true
Attachment #742387 -
Flags: review?(Ms2ger)
Attachment #742692 -
Flags: review?(Ms2ger)
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 742692 [details] [diff] [review] patch Review of attachment 742692 [details] [diff] [review]: ----------------------------------------------------------------- Would be nice to have a test, but I guess it's going to be annoying to close the dialog again. Please try to write one, but don't spend too much time on it if it doesn't work out.
Attachment #742692 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
a small mochitest has been added. https://tbpl.mozilla.org/?tree=Try&rev=1d53f920a815
Attachment #742692 -
Attachment is obsolete: true
Attachment #742990 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d82aee516d10
Flags: in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 7•11 years ago
|
||
Needed to rev the uuids to fix test failures. https://hg.mozilla.org/integration/mozilla-inbound/rev/44cfaf0cc991
https://hg.mozilla.org/mozilla-central/rev/d82aee516d10 https://hg.mozilla.org/mozilla-central/rev/44cfaf0cc991
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
||
Updated•11 years ago
|
Keywords: dev-doc-needed
|
||
Comment 9•11 years ago
|
||
Added info in: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23 https://developer.mozilla.org/en-US/docs/Web/API/window.confirm https://developer.mozilla.org/en-US/docs/Web/API/window.alert
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•