861820 - Display "Unknown" if the phone number is not available on the SIM card (from Vodafone ES, Movistar, etc.)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Hubert Figuiere [:hub]]

Setting > Device Info

There is no phone number displayed.

This is with the Vodafone ES sim card that I got here.

Comment 1

[Marcia Knous [:marcia]]

I see this as well with the latest 1.0.1 build using Happy Movil SIM card.

Comment 2

[Hubert Figuiere [:hub]]

Nor do I get it with the m2m Solutions (telefonica) Movistar.

Comment 3

[:gerard-majax]

Phone number is stored in ICC EF_MSISDN file. According to the specs http://www.etsi.org/deliver/etsi_ts/151000_151099/151011/04.14.00_60/ts_151011v041400p.pdf it is "Optional".

Comment 4

[:gerard-majax]

ETSI TS 31.102 also specifies it as optional, confere http://www.etsi.org/deliver/etsi_ts/131100_131199/131102/08.04.00_60/ts_131102v080400p.pdf page 38.

Comment 5

[:gerard-majax]

MSISDN should be here if service #21 is available. This is not checked in getSST() method of ril_worker.js.

Comment 6

[Hubert Figuiere [:hub]]

I tested the SIM card in my Samdroid phone and it says "Unknown" for the phone number. Maybe we should display this instead of a blank field.

Comment 7

[Hubert Figuiere [:hub]]

Attachment: Pull request

Proposed patch. Against v1-train.

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 737942 [details] [review]
Pull request

I'm not a Settings app peer, so better to ask :kaze for review, but quick comments:

- we don't send PRs against v1-train directly, we land on master then uplift (if we get the approvals)
- the patch contains new l10n-keys, if we want the patch to be upliftable we need a l10n review

Comment 9

[Hubert Figuiere [:hub]]

I wasn't sure who was peer :-/ I'll ask :kaze.

How do I ask for a l10n review?

(I did against v1-train because that's what I run)

Comment 10

[Hubert Figuiere [:hub]]

Attachment: Pull request

Against master

Comment 11

[Hubert Figuiere [:hub]]

Attachment: Pull request

Rebased PR.

Comment 12

[Fabien Cazenave [:kaze]]

Thanks for the patch. I have a few remarks, see my comments on github.

Comment 13

[Hubert Figuiere [:hub]]

I have updated the PR request.

Comment 14

[Fabien Cazenave [:kaze]]

Comment on attachment 753313 [details] [review]
Pull request

LGTM

Comment 15

[Binyamin]

Also Latvian and Israeli SIM cards does not display phone number, perhaps no phone number detected from any SIM.

Comment 16

[Hubert Figuiere [:hub]]

Merged

https://github.com/mozilla-b2g/gaia/commit/38760b3a5e17172440b2f79c62af575c87f4d54e

Comment 17

[Hubert Figuiere [:hub]]

(In reply to Binyamin from comment #15)
> Also Latvian and Israeli SIM cards does not display phone number, perhaps no
> phone number detected from any SIM.

This is optional. Some carrier have it, some don't. That's the gist of this bug. T-Mobile Germany for example has it.