862209 - Defect: Unloaded websites reloading after closing them while using "tabs from last time"

Status: RESOLVED WONTFIX

(Firefox for Metro Graveyard :: Shell, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

"Unloaded" tabs that appear "white" in the "Tab App Bar" are re-loaded into Firefox Metro despite being closed when "tabs from last time" is selected under "Options"

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go into the "Settings" charm and select "tabs from last time" from "Options"
3) Open three different tabs (Twitter, Facebook, CNN)
4) Once all the tabs are opened, close Firefox Metro by sliding the window to the bottom of the screen
5) Repeat Step #1
6) Two of the three tabs will be "unloaded" and appear as "white" in the "Tab App Bar"
7) Close one of the "unloaded" tabs using the "X" in the "Tab App Bar"
8) Close Firefox Metro
9) Repeat Step #1 (You will notice that once you reopen Firefox Metro again, the tab that you closed re-appears despite the user closing it)

Current Behavior:

- "Unloaded" websites are reloaded into Firefox Metro after they have been closed when re-opening Firefox Metro

Expected Behavior:

- Once you close a tab, it should stay closed despite its state when you re-open Firefox Metro and have "tabs from last time" selected

Comment 1

[Brian R. Bondy [:bbondy]]

Nice find, for what it's worth I hate this tabs on demand feature. I can see not loading them at startup, but I think the tabs should eventually be loaded on both Metro and Desktop.

Comment 2

[Asa Dotzler [:asa]]

We should absolutely change that tabs on demand pref for Metro. If we offer "remember" as a v1 feature, we have to load the background tabs. If we don't get that, I'd prefer we drop the feature for v1 and come back  at it for v2.

Comment 3

[Brian R. Bondy [:bbondy]]

p=1

Comment 4

[Jim Mathies [:jimm]]

pref: browser.sessionstore.restore_on_demand
http://mxr.mozilla.org/mozilla-central/source/browser/metro/profile/metro.js#124

Comment 5

[Allison Naaktgeboren :ally]

Attachment: pref change

This is the pref change, *but* try as I might I can't get steps 6 or step 9 in the str to reproduce either in -metrodesktop or in immersive, so I can't say whether or not this fixed it. :(

Jim, Brian, Kamil, any insights?

Comment 6

[Brian R. Bondy [:bbondy]]

are you sure this option is set?

> "tabs from last time" from "Options"

Maybe you closed via the application list on the left edge of the screen (via right click/close) after changing the option and then the options didn't save? (There's a different bug filed for that).

I reproduced this just after Kamil posted a couple weeks ago but haven't retried since then.

Comment 7

[Allison Naaktgeboren :ally]

Comment on attachment 743921 [details] [diff] [review]
pref change

I can't reproduce the str, but with bbondy's help, I'm reasonably convinced that the feature is disabled when the pref is flipped. I guess there's nothing else to do here? Over to review it goes.

Comment 8

[Brian R. Bondy [:bbondy]]

Comment on attachment 743921 [details] [diff] [review]
pref change

Review of attachment 743921 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Ally, I tried this pref change locally but unfortunately the problem isn't fixed for me. 
Here's how I reproduced (in the immersive environment):
1. Set the restore tabs from last time option
2. Close via drag Metro browser down from top to bottom of screen
3. re-opened metro firefox.
4. Opened 3 tabs with different urls loaded.
5. Closed via drag Metro browser down from top to bottom of screen
6. re-opened metro firefox, note 3 tabs are loaded
7. Opened the tab bar and closed 2 of the sites without switching to them.
8. Closed via drag Metro browser down from top to bottom of screen
9. Opened

At 9 I expected to see only 1 tab left over, but all 3 were left over.  The pref change seemed to have no effect.

Comment 9

[Allison Naaktgeboren :ally]

n(In reply to Brian R. Bondy [:bbondy] from comment #8)
> Comment on attachment 743921 [details] [diff] [review]
> pref change

> At 9 I expected to see only 1 tab left over, but all 3 were left over.  The
> pref change seemed to have no effect.

Try as I might, I cannot get this to reproduce on my vaio. >.< Meeting with Kamil tomorrow via the interwebs to try and shake this out.

Comment 10

[Brian R. Bondy [:bbondy]]

I'm using a vaio too by the way, strange. What do you see at step 9?  Only 1 tab left over? You aren't switching to the tabs before closing them right?

Comment 11

[Allison Naaktgeboren :ally]

(In reply to Brian R. Bondy [:bbondy] from comment #10)
> I'm using a vaio too by the way, strange. What do you see at step 9?  Only 1
> tab left over? You aren't switching to the tabs before closing them right?

Yea, just one, and I'm not switching tabs to close them. Kamil patiently went over it with me and the steps match (I was hoping I was doing something wrong).

The best guess I got is that I have a local build & he has one from the nightly ftp server, and some how that's messing with things.

Comment 12

[Allison Naaktgeboren :ally]

I got it to work on today's m-c! I am delighted.

Comment 13

[Allison Naaktgeboren :ally]

The pref applies, but does not fix the issue. Something else is going on.

p=5?

Comment 14

[Allison Naaktgeboren :ally]

...I could reproduce this on m-c last night, but after my morning pull today, I no longer can. Can those of you (Kamil, bbondy) who had reliable reproductions see if you can?

Comment 15

[Brian R. Bondy [:bbondy]]

Hey Ally,

I can still reproduce it with today's Nightly build.  I'd recommend just getting Marco to remove this from this iteration and then someone can take it on a later iteration that can reproduce it.  I think we could lower the point value too if someone who can reproduce it works on it. Fixing something that you can't reproduce consistently is way harder as you know :)

Comment 16

[Brian R. Bondy [:bbondy]]

We're removing this option in bug 872096, so I'm moving this to v2.
In v2 we can work on this if we decide to re-introduce the option.

Comment 17

[Kamil Jozwiak [:kjozwiak]]

This bug is still happening even with the "always show tabs" being removed. Simply enabling "tabs from last time" and then following the steps in Comment 0 will reproduce the issue. 

If you close a tab and then close Firefox Metro by sliding it to the bottom, re-opening the browser will have all the tabs opened including the one closed.

Comment 18

[Brian R. Bondy [:bbondy]]

Thanks Kamil, moving this back to v1triage based on the info in Comment 17. We moved it in Comment 16 because we thought it would go away anyway, but it hasn't.

Comment 19

[Asa Dotzler [:asa]]

Showing tabs from last time is not a user story we agreed to support in V1.  It's buggy and I recommend it be removed from v1. That would make this V2 material.