862666 - geolocation settings tests fail with undefined mozSettings after bug 859601

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

After bug 859601, there is now a timing component to accessing mozSettings.  This causes the following test cases to fail when run individually or early in the mochitest run:

  dom/tests/mochitest/geolocation/test_mozsettings.html
  dom/tests/mochitest/geolocation/test_mozsettingsWatch.html

The current mochitest division on try does not trigger this, but it was exposed while working on bug 847279.

The solution recommend by reuben is to use addLoadEvent() to delay until mozSettings is available.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Handle mozSettings async creation using addLoadEvent().

Try showing the problem:

  https://tbpl.mozilla.org/?tree=Try&rev=979663f54c28

Try showing fix (ignore the android tests):

  https://tbpl.mozilla.org/?tree=Try&rev=e0b860105578

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78ccd7f5313f

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78ccd7f5313f