Closed
Bug 862838
Opened 11 years ago
Closed 11 years ago
[MakeAPI] Use GET for Search endpoint
Categories
(Webmaker Graveyard :: MakeAPI, defect)
Webmaker Graveyard
MakeAPI
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
References
Details
(Whiteboard: [MakeAPI])
Attachments
(1 file, 1 obsolete file)
Currently it's using POST to hit the search API, but it should be GET.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → chris
|
|
Assignee | |
Comment 1•11 years ago
|
||
https://github.com/mozilla/MakeAPI/pull/13
Attachment #739218 -
Flags: review?(schranz.m)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 739218 [details] [review] Fix Routes, make Search use GET R+ from me.
Attachment #739218 -
Flags: review?(schranz.m) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Merged: https://github.com/mozilla/MakeAPI/commit/dc799dad16419b6e83ac0bc39129e5d08cf34ef2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•11 years ago
|
||
Gotta fix this to use QueryStrings.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 5•11 years ago
|
||
This patch makes the Client library convert the search object into a string, then URL encode it. it's then converted back into a JSON Object on the server.
Attachment #739218 -
Attachment is obsolete: true
Attachment #739651 -
Flags: review?(schranz.m)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 739651 [details] [review] https://github.com/mozilla/MakeAPI/pull/18 As noted in IRC, there seem to be issues with doing search and also applying a sortByField.
Attachment #739651 -
Flags: review?(schranz.m) → review-
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 739651 [details] [review] https://github.com/mozilla/MakeAPI/pull/18 The issues with sorting are present without this patch. file a new bug for it plz.
Attachment #739651 -
Flags: review- → review?
|
|
Assignee | |
Updated•11 years ago
|
Attachment #739651 -
Flags: review? → review?(schranz.m)
|
|
||
Comment 8•11 years ago
|
||
Comment on attachment 739651 [details] [review] https://github.com/mozilla/MakeAPI/pull/18 Land this, but don't close the bug until I file a new bug on the mentioned issue.
Attachment #739651 -
Flags: review?(schranz.m) → review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
Merged: https://github.com/mozilla/MakeAPI/commit/409c6e98b98804006ac873230501ea6885fb9ade close once that ticket is filed.
Flags: needinfo?(schranz.m)
|
|
||
Comment 10•11 years ago
|
||
Filed bug 864353.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: needinfo?(schranz.m)
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•