862996 - Put text headings back in the tab menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Ian Barlow (:ibarlow)]

http://cl.ly/image/0d3q243A2Q3A

We've been getting a lot of negative feedback that the icons are unclear on their own, and using text labels instead is just a nicer, more communicative design. The fact that someone pointed out that they looked like a moustache and a tophat didn't help, either.


Let's put text back in the tabs everywhere except in the tablet sidebar, where we'll keep the icons due to space constraints.

I realize there are potential localization concerns, but given the smaller text label size and fewer elements in the title bar than before, we have more room to work with now. 


For the text, please use Roboto Bold 12sp, white with 60% opacity

Comment 1

[Aaron Train [:aaronmt]]

(In reply to Ian Barlow (:ibarlow) from comment #0)
> The fact that someone pointed out that they looked like a moustache
> and a tophat didn't help, either.

http://www.am.ub.edu/~carrasco/bichos/porco2.jpg

Comment 2

[Ian Barlow (:ibarlow)]

I rest my case. :)

Comment 3

[Kartikaya Gupta (email:[e-mail])]

\o/

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

OMG! OMG! OMG!!!
So, I made the ImageButton a Button. Since Button inherits from TextView, the "iconified" one is just a compound-drawable. If it displays the text, it displays it happily! :O :O
We are becoming super efficient in using very less layouts! :O

Comment 5

[Aaron Train [:aaronmt]]

Land it?

Comment 6

[Ian Barlow (:ibarlow)]

Do it do it

Comment 7

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/14be1f919f01

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/14be1f919f01