863035 - WebSMS: use 'null' to reset SmsFilter::read and threadId

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

See bug 854790 comment 20, bug 854790 comment 28 and bug 733320 comment 33. Other attributes in SmsFilter use 'null' for reset.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Reset a already set attribute of SmsFilter is not really used in Gaia. Won't nominate for leo+ here.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

try https://tbpl.mozilla.org/?tree=Try&rev=39df1ef28abf

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 738757 [details] [diff] [review]
patch

Review of attachment 738757 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/2dd3e8012af4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2dd3e8012af4