863077 - DataChannel causes 5450 bytes leaked (DtlsIdentity, Mutex, NrIceCtx, NrIceMediaStream, NrIceResolver, ...)

Status: RESOLVED DUPLICATE of bug 862744

(Core :: WebRTC: Networking, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: leaking mochitest

With the attached patch applied to the current m-c changeset the basic audio peerconnection test will cause various leaks:

TEST-INFO | leakcheck | leaked 1 DtlsIdentity (32 bytes)
TEST-INFO | leakcheck | leaked 2 Mutex (48 bytes)
TEST-INFO | leakcheck | leaked 1 NrIceCtx (192 bytes)
TEST-INFO | leakcheck | leaked 3 NrIceMediaStream (504 bytes)
TEST-INFO | leakcheck | leaked 1 NrIceResolver (40 bytes)
TEST-INFO | leakcheck | leaked 18 NrSocket (3600 bytes)
TEST-INFO | leakcheck | leaked 1 ReentrantMonitor (32 bytes)
TEST-INFO | leakcheck | leaked 2 StringAdopt (2 bytes)
TEST-INFO | leakcheck | leaked 1 TransportFlow (176 bytes)
TEST-INFO | leakcheck | leaked 1 VerificationDigest (88 bytes)
TEST-INFO | leakcheck | leaked 1 nsDNSService (144 bytes)
TEST-INFO | leakcheck | leaked 1 nsIDNService (120 bytes)
TEST-INFO | leakcheck | leaked 1 nsPrefBranch (128 bytes)
TEST-INFO | leakcheck | leaked 1 nsSocketTransportService (216 bytes)
TEST-INFO | leakcheck | leaked 1 nsStringBuffer (8 bytes)
TEST-INFO | leakcheck | leaked 1 nsTimerImpl (96 bytes)
TEST-INFO | leakcheck | leaked 1 nsUnicodeNormalizer (24 bytes)
 0:14.33 TEST-UNEXPECTED-FAIL| leakcheck | 5450 bytes leaked (DtlsIdentity, Mutex, NrIceCtx, NrIceMediaStream, NrIceResolver, ...)


Steps:
1. Apply patch
2. Run: ./mach mochitest-plain dom/media/tests/mochitest/test_peerConnection_basicAudio.html
3. Once the test has been finished close the browser
4. Check the leak output

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The number of bytes leaked varies between different runs. Today it went up to 15kB in one case.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

This *looks* like a failure of a transportflow to get shut down at test end; there are no DataChannel objects leaked....  

Can you upload the full output with NSPR_LOG_MODULES=signaling:5,mtransport:5,datachannel:5
?

Thanks!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: logfile

The log file as requested. I just want to add (if it matters) that I'm running a debug optimized build with trace-malloc enabled. I will rebuild without optimizations now.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This leak is a regression caused by the first patch landed on bug 862744 and will be fixed once the second patch on that bug has been landed in mozilla-central.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Dupping since the bug is being handled by reopening bug 862744 (and that fix is already on inbound)