Closed
Bug 863092
Opened 11 years ago
Closed 11 years ago
Make mach run and mach debug run firefox -no-remote
Categories
(Firefox Build System :: Mach Core, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: joe, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
1.89 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Ehsan promised he'd do this if I filed the bug. Well, here it is!
Flags: needinfo?(ehsan)
Comment 1•11 years ago
|
||
Note that you can currently do this with "mach run -no-remote" and "mach debug -no-remote". I think it's a reasonable request to include -no-remote by default, but maybe there should be a way to override it in case you actually *do* want to pass a new command line to the existing process. How useful would this be as a default option? Are there many cases where you need -no-remote but don't also need other options like -P or -profile?
Updated•11 years ago
|
Comment 2•11 years ago
|
||
see also https://bugzilla.mozilla.org/show_bug.cgi?id=858629
Comment 3•11 years ago
|
||
(fwiw, i have no idea what use case passing -profile serves without -no-remote or if that is just a bug)
Assignee | ||
Comment 4•11 years ago
|
||
There's really very little reason to not use -no-remote for local builds. The only reason that I can think of is if you're trying to debug our remoting code, and I would definitely not object if somebody writes a patch to add an exception about that when they need it. ;-)
Flags: needinfo?(ehsan)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #738868 -
Flags: review?(gps)
Comment 6•11 years ago
|
||
Comment on attachment 738868 [details] [diff] [review] Patch (v1) Review of attachment 738868 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense to me! I *always* run with -no-remote. Although I would feel better if we addressed the case where people don't want -no-remote. Follow-up I suppose.
Attachment #738868 -
Flags: review?(gps) → review+
Comment 7•11 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4) > There's really very little reason to not use -no-remote for local builds. > The only reason that I can think of is if you're trying to debug our > remoting code, and I would definitely not object if somebody writes a patch > to add an exception about that when they need it. ;-) Or if you live on the metal and want bleed-of-the-edge firefox for your everyday browser (and no, I don't do that ;)
Assignee | ||
Comment 8•11 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/dcc71e2b291c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•