863191 - [Buri][Translation]The subheads of some Settings Item are not translated immediately.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.077
 Firefox os  v1.0.1
 Mozilla build ID:20130414070204
 
 +++ This bug was initially created as a clone of Bug #441940 +++
 
 Created an attachment (id=392742)
 snapshot
 
 DEFECT DESCRIPTION:
 
  The subhead of SIM security isn't translation immediate.
 
  REPRODUCING PROCEDURES:
 
  1.Settings->language->change system language to another language->back to settings main screen->the subhead of SIM security isn't translation==>KO
 
  EXPECTED BEHAVIOUR:
  ==>The subhead of SIM security should be translated.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:SW122+DT/TEF
 
  USER IMPACT:Medium
 
  REPRODUCING RATE:5/5
 
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #441940 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: Picture 2

Clone from brother

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: Picture 1

Clone from brother

Comment 5

[sync-1]

Clone from brother

Comment 6

[sync-1]

Attachment: snapshot

Clone from brother

Comment 7

[sync-1]

Dear all,
 As the pics show, almost all subheads on the Settings main panel have problems in translation.
 By the way, this bug does not occur every time. You should switch language a couple times when you try to reproduce.
 IMO, it is not friendly if we dont fix it. So lets check the code and find why!

Comment 8

[xiaokang.chen]

Hi guys, can anybody check this ?

Comment 9

[xiaokang.chen]

hey, kkuo, can you check this or find someone to do it?

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

adding l10n team

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

and please nominate for blocker at this stage for bugs requiring immediate attentions. Thanks

Comment 12

[xiaokang.chen]

Hi Fabien,
Can you check on this? Thanks!

Comment 13

[Axel Hecht [:Pike]]

The report sounds like this is a gaia software issue.

Comment 14

[Fabien Cazenave [:kaze]]

(In reply to xiaokang.chen from comment #12)
> Hi Fabien,
> Can you check on this? Thanks!

Hi! Yes, sure. I’m on PTO today but I’ll look at it ASAP.

Comment 15

[Daniel Coloma:dcoloma]

The bug is reported based on a build that is *one month old* as of today. 

 - Mozilla build ID:20130414070204

Questions for the reporter:

If this was deemed so critical why it was not nominated until 3 days ago?
Have you checked with a more recent build before nominating it?

This is working for me when switching between Spanish/Portuguese/English. I think this was fixed in:

https://github.com/mozilla-b2g/gaia/commit/aff876b051c51d091cecf322b90c4f0093281b5e

which makes me suspect it is a duplicated of bug 836687. 

qawanted to re-check this.

Comment 16

[xiaokang.chen]

Attachment: screenshot of german

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.094
Firefox os  v1.0.1
Mozilla build ID:20130502070201
Still has this problem just like the screenshot.

Comment 17

[xiaokang.chen]

Attachment: screenshot of polish

Comment 18

[Daniel Coloma:dcoloma]

Arthur, could you please check what the issue is here?

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

The root cause is that the content of these elements are dynamically assigned in the script, which is the same as bug 836687. The content is not localized if we do not set corresponding l10nId to the element.

Comment 20

[Daniel Coloma:dcoloma]

OK, can qa check which are the settings that are affected?

The only ones that are not properly localized in any language (Spanish, Portuguese and Polish) are the subheaders of "Call Settings" and "Cellular and Data" when there is No SIM (only on that situation).

Please note that re-opening the app fixes that temporary situation. 

I think we should not block on this given that this is just two captions, only when no SIM Card is inserted and restarting the app fixes it.

Comment 21

[Delphine Lebédel [:delphine - Use needinfo]]

Daniel: are you saying that you like us to spot-check the other areas than SIM security, to see if this issue happens elsewhere?

Comment 22

[Daniel Coloma:dcoloma]

(In reply to delphine from comment #21)
> Daniel: are you saying that you like us to spot-check the other areas than
> SIM security, to see if this issue happens elsewhere?

exactly, the other areas spotted in the initial description work for me now. Any other strings to be localized apart from the ones I mentioned in comment 20.

Comment 23

[Delphine Lebédel [:delphine - Use needinfo]]

So on today's Inari, v1.0.1 Commercial RIL, strings not properly translated appear with all 9 locales present on this build, when changing from one locale to another. This only happens when no SIM card is inserted, and only under "Call Settings" and "Cellular and Data".

Gaia   57188a05fe5b669fc98bfcc18a49c9b3effdac06
BuildID 20130514070202
Version 18.0

Killing the app solves problem.

I've spot-checked the settings and this seems to happen only under "Call Settings" and "Cellular and data". The rest appears correctly translated, according to the locale chosen

Please let me know if you need further testing

Comment 24

[xiaokang.chen]

(In reply to delphine from comment #23)
> So on today's Inari, v1.0.1 Commercial RIL, strings not properly translated
> appear with all 9 locales present on this build, when changing from one
> locale to another. This only happens when no SIM card is inserted, and only
> under "Call Settings" and "Cellular and Data".
> 
> Gaia   57188a05fe5b669fc98bfcc18a49c9b3effdac06
> BuildID 20130514070202
> Version 18.0
> 
> Killing the app solves problem.
> 
> I've spot-checked the settings and this seems to happen only under "Call
> Settings" and "Cellular and data". The rest appears correctly translated,
> according to the locale chosen
> 
> Please let me know if you need further testing

Dear delphine,
The subhead of wifi also not translated correctly as shown in the attachment of comment #16 and #17

Comment 25

[Delphine Lebédel [:delphine - Use needinfo]]

As per comment 20 and 22, I as well only see the captions under "Call Settings" and "Cellular and Data" improperly localized
The rest looks ok.

Comment 26

[Alex Keybl [:akeybl]]

Reboot (In reply to Daniel Coloma:dcoloma from comment #20)
> Please note that re-opening the app fixes that temporary situation. 

Not a blocker.

Comment 27

[xiaokang.chen]

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.105
Firefox os  v1.0.1
Mozilla build ID:20130512070209

The subhead of wifi don't translated correctly in romanian, polish, cetch. 

And the subhead don't translated correctly after I restart the Settings app.

Comment 28

[Arthur Chen [:arthurcc][inactive after 6/30]]

xiaokang, the subhead of wifi not localized seems resulted from the lack of string in the localization file. Stas, could you help check it?

Comment 29

[Axel Hecht [:Pike]]

(In reply to Arthur Chen [:arthurcc] from comment #28)
> xiaokang, the subhead of wifi not localized seems resulted from the lack of
> string in the localization file. Stas, could you help check it?

That's bug 865955.

Comment 30

[xiaokang.chen]

Dear Arthur,
When will you fix the "no sim card" issue? Thanks.

Comment 31

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/9840

Kaze, please help review the change, thanks!

Comment 32

[Fabien Cazenave [:kaze]]

Comment on attachment 750929 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9840

The rationale looks good but the code could be factorized. Please look at my comment on github and ask for another review.

Comment 33

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 750929 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9840

Patch updated based on the comment. Also use the localize utility function for strings without arguments.

Comment 34

[Fabien Cazenave [:kaze]]

Thanks for the code factorization Arthur, this looks good. I just have a last nitpick before I can r+ this, please check my comments on github.

Comment 35

[Arthur Chen [:arthurcc][inactive after 6/30]]

Kaze, thank you for reviewing. Patch updated based on the comments.

Comment 36

[Fabien Cazenave [:kaze]]

Comment on attachment 750929 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9840

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/572d81a5b6396711fa67e06b790314cc8dec6efd

Comment 38

[Joe Cheng [:jcheng] (please needinfo)]

bug 872939 is tef+, tef+ this one for uplift

Comment 39

[Gareth Aye [:gaye] (back from PTO)]

This bug was partially uplifted.

Uplifted 572d81a5b6396711fa67e06b790314cc8dec6efd to:
v1-train: 0e154e04e746263afa5bfe4322ec7c68ee41d3a9

Commit 572d81a5b6396711fa67e06b790314cc8dec6efd didn't uplift to branch v1.0.1

Comment 40

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.0.1: https://github.com/mozilla-b2g/gaia/commit/460bd2dbe44b5d9d6f497f5944e1b6c69db82c81

Comment 41

[sarsenyev]

This bug no longer reproduces on tested devices
All strings are translated to a target language

Buri Build ID: 20130531070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9df4d6efd664
Gaia   5691a16fff8e1403c75ed9d6f3a443b7e58198c6

Inari Build ID: 20130531070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/be5c2ee11d02
Gaia: e7114bdf4078274fc127a3b2a58dad91d6884219

Comment 42

[sarsenyev]

Unagi Build ID: 20130531070205
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/4f318822e72c
Gaia: e1c59baed29e4665d1da9392f86239272073f07a