863377 - Can no longer catch socket.error in marionette client

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Kumar McMillan [:kumar]]

As of the Python marionette_client version 0.9 I can no longer catch socket.error and this makes programmatic access difficult.

This is the culprit around line 400 of marionette.py:

    def start_session(self, desired_capabilities=None):
        try:
            # We are ignoring desired_capabilities, at least for now.
            self.session = self._send_message('newSession', 'value')
        except:
            traceback.print_exc()
            self.check_for_crash()
            sys.exit()

Why not catch and re-raise like this?

    def start_session(self, desired_capabilities=None):
        try:
            # We are ignoring desired_capabilities, at least for now.
            self.session = self._send_message('newSession', 'value')
        except:
            exc, val, tb = sys.exc_info()
            self.check_for_crash()
            raise exc, val, tb

My script was catching a socket.error and reacting by forwarding ports: https://github.com/kumar303/ezboot/blob/70fb41fe53ee17d377424065706909651e037d60/ezboot/__init__.py#L120-L124

Comment 1

[Kumar McMillan [:kumar]]

the workaround is to catch SystemExit which is fragile

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - fix

Good catch, I forgot you could raise like that. Kumar, do you need this on b2g18 too?

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 739639 [details] [diff] [review]
Patch 1.0 - fix

Review of attachment 739639 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb2202cf3489

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/eb2202cf3489

Comment 6

[Kumar McMillan [:kumar]]

Thanks Andrew. I don't think it matters if this lands on b2g18 or not. Just let me know when a new version of the lib is available on PyPI and when gaiatest has been updated to depend on it.

Comment 7

[Andrew Halberstadt [:ahal]]

(In reply to Kumar McMillan [:kumar] from comment #6)
> Thanks Andrew. I don't think it matters if this lands on b2g18 or not. Just
> let me know when a new version of the lib is available on PyPI and when
> gaiatest has been updated to depend on it.

If this is blocking something we can bump the version specifically for this. Otherwise we'll just wait until there's a need to.

Comment 8

[Kumar McMillan [:kumar]]

It's not blocking, we can work around by catching SystemExit

Comment 9

[Malini Das [:mdas] - Away, not checking bugmail]

A new version of marionette has just been released on pypi (version 0.5.25), but can this be uplifted to b2g18? Best to keep things in sync so we don't go hunting for bugs when the next conflict happens!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/14b6336f254d