Closed
Bug 863513
Opened 11 years ago
Closed 11 years ago
Be less verbose about DM exceptions
Categories
(Testing Graveyard :: Mozpool, defect)
Testing Graveyard
Mozpool
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
Details
Attachments
(1 file)
1.82 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
This is a little much: sut.cli ERROR - [2013-04-18 16:06:05,514] Exception initiating DeviceManager! sut.cli ERROR - [2013-04-18 16:06:05,514] Traceback (most recent call last): File "/opt/mozpool/frontend/lib/python2.7/site-packages/mozpool/bmm/sut.py", line 19, in sut_verify DeviceManagerSUT(device_fqdn, retryLimit=1) File "/opt/mozpool/frontend/lib/python2.7/site-packages/mozdevice/devicemanagerSUT.py", line 45, in __init__ self.getDeviceRoot() File "/opt/mozpool/frontend/lib/python2.7/site-packages/mozdevice/devicemanagerSUT.py", line 693, in getDeviceRoot data = self._runCmds([{ 'cmd': 'testroot' }]) File "/opt/mozpool/frontend/lib/python2.7/site-packages/mozdevice/devicemanagerSUT.py", line 151, in _runCmds self._sendCmds(cmdlist, outputfile, timeout, retryLimit=retryLimit) File "/opt/mozpool/frontend/lib/python2.7/site-packages/mozdevice/devicemanagerSUT.py", line 142, in _sendCmds raise DMError("Remote Device Error: unable to connect to %s after %s attempts" % (self.host, retryLimit)) DMError: Remote Device Error: unable to connect to stone-ridge-panda-03.sec.scl3.mozilla.com after 1 attempts
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #741456 -
Flags: review?(mcote)
Comment 2•11 years ago
|
||
Comment on attachment 741456 [details] [diff] [review] bug863513.patch Review of attachment 741456 [details] [diff] [review]: ----------------------------------------------------------------- This is fine if the extra info is really unwanted. The only reason I put it in is due to historical experiences trying to diagnose DeviceManager failures, which were often tricky to pinpoint. But mozpool's design is so much better than the previous iteration of automation, so full tracebacks could indeed be overkill.
Attachment #741456 -
Flags: review?(mcote) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Mozpool also sees mostly (all, so far) ignorable errors, since it falls back to relay operations when DM fails.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•