Closed Bug 863600 Opened 11 years ago Closed 11 years ago

Intermittent browser_toolbox_options.js on Windows PGO builds | Test timed out

Categories

(DevTools :: Framework, defect, P1)

Product:
DevTools
Component:
Framework
Platform:
x86
Windows 7
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: past, Assigned: past)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Patch v1
1.57 KB, patch
Details | Diff | Splinter Review 
This happened on the landing push for bug 851546, but it was merged to m-c before I could back it out, so we need to fix it ASAP.

In general PGO builds are highly optimized and can expose races more easily than regular optimized builds.

https://tbpl.mozilla.org/php/getParsedLog.php?id=21983351&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=21983639&tree=Fx-Team
https://tbpl.mozilla.org/php/getParsedLog.php?id=21983135&tree=Fx-Team

16:30:14  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options.js | Test timed out
16:31:19  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_remote.js | uncaught exception - Error: consoleActor already exists at chrome://global/content/devtools/dbg-server.js:358
16:31:49  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_remote.js | Test timed out
16:31:49  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/profiler/test/browser_profiler_remote.js | Found a tab after previous test timed out: data:text/html;charset=utf8,<p>JavaScript%20Profiler%20test</p>
16:41:35  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options.js | leaked until shutdown [nsGlobalWindow #9642 about:blank]
16:41:35  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options.js | leaked until shutdown [nsGlobalWindow #9645 about:blank]
16:41:35  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options.js | leaked until shutdown [nsGlobalWindow #9643 about:blank]
16:41:35  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options.js | leaked until shutdown [nsGlobalWindow #9646 about:blank]
Hey, look who's back:

16:29:46     INFO -  InternalError: too much recursion: get_webProgress@chrome://global/content/bindings/browser.xml:378
16:29:46     INFO -  removeProgressListener@chrome://global/content/bindings/browser.xml:465
16:29:46     INFO -  TWPL_destroy@resource://app/modules/devtools/Target.jsm:503
16:29:46     INFO -  @resource://app/modules/devtools/Target.jsm:394
16:29:46     INFO -  TBOX_destroy@resource://app/modules/devtools/Toolbox.jsm:765
16:29:46     INFO -  cleanup@chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options.js:137
16:29:46     INFO -  toggleTools@chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options.js:105
16:29:46     INFO -  checkRegistered@chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_options.js:129
1
Completely untested idea: change line 105 in the test to executeSoon(cleanup). This should move the last 5-10 stack frames on the next turn of the event loop, avoiding the stack overflow.
Attached patch Patch v1 — — Splinter Review 
On second thought, let's not wait until the last minute to stop adding frames on the stack.
Assignee: nobody → past
Status: NEW → ASSIGNED
Thanks for fixing this Panos. I never knew that just a 5 level recursion could lead to too much recursion error on PGO.
It seems that the patch worked, but I don't have the time to merge to m-c today.
https://hg.mozilla.org/mozilla-central/rev/1e16b3af2489
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: