86364 - Inbox is now empty in the mail reader

Status: VERIFIED FIXED

(MailNews Core :: Database, defect)

Description

[Jean-Max Reymond]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.11-2mdk i686; en-US; rv:0.9.1)
Gecko/20010607
BuildID:    2001060713

I have lost all the message in Inbox
Now, there is 0 messages
In the mail directory, all seems OK with a Inbox file of 13M

Reproducible: Always
Steps to Reproduce:
1.read my Inbox
2.
3.

Comment 1

[Andrés G. Aragoneses]

This stuff happened to me usually when using old version Netscape 6.01. 
In fact, I had a solution for this when it happened:

1. Close all mozilla windows.
2. Rename your Inbox mail file as, for example, "Inbox-".
3. Create a blank file (size 0 bytes) an name it as "Inbox".
4. Open Mozilla Mail and see againt that your Inbox is empty.
5. Close again mozilla windows.
6. Delete file "Inbox" and rename again the file "Inbox-" to "Inbox".
7. Open Mozilla Mail and open Inbox.
8. Mozilla will say "Building summary file for Inbox" and all your messages will
be there again.

That's the method I used. Hope it's useful for you.
I don't know why it happens again with this new Moz version 0.9.1.

Comment 2

[Jean-Max Reymond]

Attachment: Explanation but not solution

Comment 3

[David :Bienvenu]

you can send me the Inbox.msf and I can look at it, but the problem is figuring
out how it got corrupted in the first place.

Comment 4

[Jean-Max Reymond]

Attachment: the corrupted summary file

Comment 5

[David :Bienvenu]

Attachment: proposed fix

Comment 6

[David :Bienvenu]

Can I get some code reviews? The fix is to detect the mork error, and in that
case, close the db, delete it, and return an error to the caller who will
regenerate the db. Thanks. This also has a potential fix for a top crasher,
checking for a null store in GetThreadForSubject.

Comment 7

[(not reading, please use [e-mail] instead)]

1)

+  else
+  {
+    // this will make the db folder info release its ref to the mail db...
+    NS_IF_RELEASE(mailDB->m_dbFolderInfo);
+    mailDB->ForceClosed();
+    NS_RELEASE(mailDB);
+    summarySpec.Delete(PR_FALSE);
+    err = NS_MSG_ERROR_FOLDER_SUMMARY_MISSING;
+  }
+  

what about setting mailDB to nsnull after you release it?

2)

after your patch, it looks like the code will look like this:

if (NS_SUCCEEDED(err))
{
  ...
  if (err != NS_OK) 
  {
     XXX // existing code
  }
}
else
{
   XXX // your new code
}
  
where XXX is the same bit of code to do the cleanup.  can you move it out into a
  method?

(note the original XXX, they set mailDB = NULL.  we should set it to nsnull.

Comment 8

[(not reading, please use [e-mail] instead)]

whoops, I forgot to add:

after you address the duplicated code, sr=sspitzer.

it looks good.

Comment 9

[(not reading, please use [e-mail] instead)]

whoops, bienvenu pointed out why we can't move it out to a method.

but he's trying a different approach to avoid duplicating the common code.

Comment 10

[David :Bienvenu]

Attachment: cleaned up fix, removed old comments, added new ones

Comment 11

[Navin Gupta]

This function sure needs some whitespace fix. Also I see that err from
 err = mailDB->OpenMDB((const char *) summarySpec, create);

is being reset here

+    err = NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE;
+    deleteInvalidDB = PR_TRUE;

Comment 12

[David :Bienvenu]

the diff is -uw, and I think I've fixed all the whitespace issues. The resetting
of the err is intentional.

Comment 13

[Navin Gupta]

r=naving 

Comment 14

[(not reading, please use [e-mail] instead)]

-*pMessageDB = NULL;
  delete mailDB;
- mailDB = NULL;
+ mailDB = nsnull;

why'd you remove the first line?

talking to david over aim, he's going to replace "delete mailDB; mailDB = NULL;"
with NS_IF_RELEASE(mailDB);

looks good, sr=sspitzer

Comment 15

[David :Bienvenu]

I removed the first line because we're initializing *pMessageDB = nsnull at the
top of the routine, so we don't need to set it in this error case because no one
else has changed it before this point in the code.

Comment 16

[(not reading, please use [e-mail] instead)]

thanks for clarifying.

sr=sspitzer

Comment 17

[David :Bienvenu]

fix checked in

Comment 18

[esther]

Is this corruption of the inbox.msf file easy to reproduce on any mail server? 
If so, can someone give me steps.  If not, Jean-Max can you confirm your mail 
box is OK now so I can verify this. Thanks,

Comment 19

[Jean-Max Reymond]

I confirm, now it is correct.
no more corruptions of any folder

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

verifying fixed per reporter's comments.