863680 - [KeyBoard] When cursor is changed from one text field to another alternate layout text field,homescreen appears and disappears for a moment.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Description

[Leo]

1. Title :When cursor is changed from one text field to another alternate layout text field,homescreen appears and disappears for a moment.
2. Precondition : Settings >> Keyboard >> Select Word Suggestion 
3. Action : Calendar >> Add account >> click username >> click password 
            Contact >> Add contact >> click Name >> click Email                     
4. Detailed Symptom (ENG.) : On changing from one input field to another alternate layout field,part of home screen appears in place of word suggestion bar and then disappear. 
5. GAIA version : D30007d
6. Expected : Word suggestion bar should disappear without any appearance of home screen.
7.Reproducibility: Y
1)Frequency Rate : 100%

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9620/files

Pointer to Github pull-request

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 746898 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9620/files

Update a patch after an off-line discussion.
Hope this can get it to work.

Hi Tim,

Could you help review this one?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 746898 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9620/files

Thanks!

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/336ee89cc64741074bf86ef31b1590a195d459f4

Comment 5

[Leo]

This issue is still reproducing.
Please check.
To reproduce the issue
Precondition : Word Suggestion ON
Action : Message >> New Message >> Input text >>Switch to "To:" field
OR
Browser >> Bookmark Entry >> Bookamark title >> Switch to Address (URL)
This issue still reproduces.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

STR for Gaia master that still can reproduce this issue,
========

open a website
Bookmark it >> Then Edit Bookmark >>
Word suggestion should be On
Switch from "Page Title" textfield to "address" textfield

I will try the steps later.
Thanks for the heads-up.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 336ee89cc64741074bf86ef31b1590a195d459f4
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 8

[Leo]

Rudy, do we have to reopen this to track the new issue or need to have a separate bug for tracking this?

Comment 9

[Leo]

Attachment: Patch for Word Suggestion Bar Hides and No Home screen appears

Hi Rudy,
Please review the attached patch for this issue.
The previous patch does not work when I checked in browser.
This patch fixes for anywhere where word suggestion bar is not 
required and it hides.

Thank you

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 772555 [details] [diff] [review]
Patch for Word Suggestion Bar Hides and No Home screen appears

Review of attachment 772555 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry that I don't think this could work.
Right now, the logic for the delay is wrong (see the comment below) and if I corrected it, the patch could not fix the issue.

BTW, because this bug has been marked as resolved, please help create another bug and nominate it as leo+.

::: apps/keyboard/js/keyboard.js
@@ +855,4 @@
>  function updateTargetWindowHeight(hide) {
>    if (IMERender.ime.dataset.hidden || hide) {
>      document.location.hash = 'hide';
> +  } else if (needsCandidatePanel() && candidatePanelEnabled) {

it should be !needsCandidatePanel() here.

Comment 11

[Wayne Chang [:wchang]]

Follow up bug @ Bug 891798

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Wayne Chang [:wchang] from comment #11)
> Follow up bug @ Bug 891798

Does this mean that we can close this bug on branches?

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I think so.
Bug 891798 has bee fixed in both master and v1-train.

Comment 14

[mdaniloff]

Verified Fixed on Latest Leo COM RIL. No part of the home screen appears in place of the word suggestion bar.


Environmental Variables
Build ID: 20130815041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/692d3414bb12
Gaia: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
Platform Version: 18.1
RIL Version: 01.01.00.019.190