863687 - Missing events (e.g. ondatachannel) when running datachannel tests

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: non-working mochitest

When running the following mochitest you will notice that no ondatachannel events are getting fired even with data connection successfully established. Having the exact same code in a standalone test it works fine.

We are blocked with the creation of any datachannel related test. Bug 796894 is the most important one here because it will get an update for the framework too. 

I will investigate what's causing this now.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: testcase (standalone)

Same code as a standalone testcase.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So the reason here is not mochitest vs. standalone, but the version of the build. While the mochitest was running on latest m-c I had a Nightly build from two days ago. This build doesn't contain the first patch as landed on bug 862744 later. After upgrading Nightly to yesterdays version the standalone testcase is also broken.

The follow-up fix on bug 862744 might help us here. I will retest in a bit after the current build is done.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Once bug 862744 is fixed it will work. Additionally to this I noticed an exception thrown inside of the ondatachannel event listener because I reference to this instead of self.

Lets wait for the landing of the second patch on bug 862744 in mozilla-central. Then we are unblocked!

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Per IRC, invalid

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No, this is not invalid. The main reason for this broken behavior was the regression introduced by the patch on bug 862744. This is fixed now.