863889 - nsWindow::Move should compare the same type of pixels when determining if we are moving the window at all

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 739834 [details] [diff] [review]
patch

Review of attachment 739834 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, the check doesn't make sense otherwise! Thanks for catching this.

(I assume there's no visible effect of this fix, as it's just correcting an optimization.)

Comment 3

[Timothy Nikkel (:tnikkel)]

(In reply to Jonathan Kew (:jfkthame) from comment #2)
> (I assume there's no visible effect of this fix, as it's just correcting an
> optimization.)

I didn't notice any bugs, just saw it while reading the code yes. But it's not an optimization we want to do with out: screwing up the similar optimization in nsWindow::Resize caused severe lag in a past bug.

Comment 4

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9d45f30cdc7

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f9d45f30cdc7