863918 - Leak with many AudioContexts

Status: RESOLVED WORKSFORME

(Core :: Web Audio, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Run debug Firefox with XPCOM_MEM_LEAK_LOG=2
2. Load the testcase
3. Quit

Result: trace-refcnt reports leak of AudioNodeEngine, AudioNodeStream, MediaStream, StreamBuffer, TimeVaryingBase, nsTArray_base

Also, it takes a while to shut down (bug 821062?).

Comment 1

[Jesse Ruderman]

Attachment: what leaked?

Comment 2

[(no longer active)]

The long pause is caused by many calls to cubeb_stream_stop, once for each AudioDestinationNode.

So, MediaStreamGraphImpl::AppendMessage contains special logic to handle messages dispatched during shutdown.  Is there anything which can happen asynchronously which would cause some of the streams to not be deleted?

Comment 3

[(no longer active)]

Also note that the leak is intermittent.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #2)
> So, MediaStreamGraphImpl::AppendMessage contains special logic to handle
> messages dispatched during shutdown.  Is there anything which can happen
> asynchronously which would cause some of the streams to not be deleted?

It sounds like there's a bug in that logic. I don't know what the bug is.

Comment 5

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.

Comment 6

[(no longer active)]

Jesse, do you still see this bug?

Comment 7

[Jesse Ruderman]

Shutdown takes about 10 seconds, but the leak is gone.