863968 - ContainerLayerOGL tries to bind non-existent buffer

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nick Cameron [:nrc]]

When we use am intermediate surface for rendering a container layer but don't composite (that is, aManager->CompositingDisabled() is true). We call fBindFramebuffer for an fbo which never got created, which causes us gl grief if we check for gl errors.

Comment 1

[Nick Cameron [:nrc]]

Attachment: fix

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 739922 [details] [diff] [review]
fix

Review of attachment 739922 [details] [diff] [review]:
-----------------------------------------------------------------

I don't want to be picky as that's an old-layers file IIUC. But I really don't like the design around here. What's this aPreviousFramebuffer argument doing and how do we know that we only have to restore this framebuffer attachment if composition is disabled? Looks fragile.

Comment 3

[Nick Cameron [:nrc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b495fe61ee4

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7b495fe61ee4