Closed
Bug 864608
Opened 11 years ago
Closed 11 years ago
Tab drag dropmarker size and/or position needs updating for Australis
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [Australis:M5])
Attachments
(2 files, 1 obsolete file)
62.91 KB,
image/png
|
Details | |
2.24 KB,
patch
|
fryn
:
review+
|
Details | Diff | Splinter Review |
When you drag a tab from one window to another, the placeholder showing where the tab will be inserted doesn't have the correct position and/or size.
Updated•11 years ago
|
Summary: Tag drag placeholder size and/or position needs updating for Australis → Tab drag placeholder size and/or position needs updating for Australis
Ideally we would like bug 674925 fixed, but for now a new indicator is indeed needed.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mnoorenberghe+bmo
Status: NEW → ASSIGNED
Whiteboard: [Australis:M5]
Assignee | ||
Comment 2•11 years ago
|
||
Stephen, how is this? The screenshot shows the indicator between two background tabs and beside a foreground tab. diff --git a/browser/themes/osx/browser.css b/browser/themes/osx/browser.css --- a/browser/themes/osx/browser.css +++ b/browser/themes/osx/browser.css @@ -2240,11 +2240,11 @@ toolbarbutton.chevron > .toolbarbutton-m * Tab Drag and Drop */ .tab-drop-indicator { list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator.png); - margin-bottom: -8px; + margin-top: -2px; } @media (min-resolution: 2dppx) { .tab-drop-indicator { list-style-image: url(chrome://browser/skin/tabbrowser/tabDragIndicator@2x.png);
Attachment #749496 -
Flags: ui-review?(shorlander)
Comment 3•11 years ago
|
||
Comment on attachment 749496 [details]
Screenshot with patch: margin-top: -2px
Stephen says that this is fine, but he prefers the dropmarker over the selected tab, not under the tab.
We select the dragged tab post-drag, so that makes sense to me too.
Attachment #749496 -
Flags: ui-review?(shorlander) → ui-review+
Comment 4•11 years ago
|
||
In the long term, we'd want to do something more like Safari — creating a space for the dragged tab, etc. — but that's really not necesssary for Australis.
Summary: Tab drag placeholder size and/or position needs updating for Australis → Tab drag dropmarker size and/or position needs updating for Australis
Assignee | ||
Comment 5•11 years ago
|
||
The z-index was adjusted so that the dropmarker appears above the selected tab (z-index: 2). On Windows and Linux we use an arrow on the bottom and I just made that slightly overlap the bottom border of the tabstrip.
Attachment #749496 -
Attachment is obsolete: true
Attachment #750602 -
Flags: review?(fyan)
Comment 6•11 years ago
|
||
Comment on attachment 750602 [details] [diff] [review] v.1 Adjust position and z-index of the dropmarker Review of attachment 750602 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #750602 -
Flags: review?(fyan) → review+
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/projects/ux/rev/3f2b96067735
Whiteboard: [Australis:M5] → [Australis:M5][fixed-in-ux]
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3f2b96067735
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M5][fixed-in-ux] → [Australis:M5]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•