Closed
Bug 864613
Opened 11 years ago
Closed 11 years ago
Take the dynamics compressor node's input chunk volume into account
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.56 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #740603 -
Flags: review?(paul)
|
||
Updated•11 years ago
|
Attachment #740603 -
Flags: review?(paul) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
Hmm, perhaps this patch is not right. I think instead of applying the volume after the dynamic range compression computations, I should do it before that...
|
|
||
Comment 3•11 years ago
|
||
Yes. A signal that is higher than the threshold value at intrinsic volume may well not trigger the effect if the input volume is in fact low enough. Sorry for overlooking that.
Flags: needinfo?(paul)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #740603 -
Attachment is obsolete: true
Attachment #740898 -
Flags: review?(paul)
|
|
||
Updated•11 years ago
|
Attachment #740898 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/f27428a02d7b
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f27428a02d7b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
Assignee | |
Comment 7•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•