Closed Bug 864752 Opened 11 years ago Closed 11 years ago

Excluded channels should start with nightly, aurora, beta and not be exactly those

Categories

(Socorro Graveyard :: Middleware, defect, P2)

Product:
Socorro Graveyard
Component:
Middleware
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: adrian, Assigned: adrian)

Details

In search, the "release" channel contains crashes from all the channels the system doesn't know of (including the "release" channel). Here is the current list of channels the middleware knows: 

beta
aurora
nightly

Everything else is potentially considered as a "release" (given it has the appropriate version number). Should we update that list, to add "nightly-ux" or the B2G channels for example?
(In reply to Adrian Gaudebert [:adrian] from comment #0)
> Everything else is potentially considered as a "release" (given it has the
> appropriate version number). Should we update that list, to add "nightly-ux"
> or the B2G channels for example?

No. There are no others (there's "default" but that's counted to release intentionally).

Anything that *starts* with "nightly", "aurora", or "beta" should be excluded, but that's it. Everything else should be counted as as release when the version number matches. And that latter filter is what excludes "nightly-*" and "aurora-*" already anyhow because those have different version numbers, only beta has the same version as release (and custom/distro builds that use "default", which should be counted against release).
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #1)
> Anything that *starts* with "nightly", "aurora", or "beta" should be
> excluded, but that's it. 

Well that's something important because it is not the case at the moment. Currently, everything that *is* beta, aurora or nightly is excluded, but nightly-* are not for example! Let's change the name of this bug and work on that (and keep the current list).
Assignee: nobody → adrian
Summary: The list of non-release channels is outdated → Excluded channels should start with nightly, aurora, beta and not be exactly those
Priority: -- → P2
(In reply to Adrian Gaudebert [:adrian] from comment #2)
> Well that's something important because it is not the case at the moment.
> Currently, everything that *is* beta, aurora or nightly is excluded, but
> nightly-* are not for example! Let's change the name of this bug and work on
> that (and keep the current list).

As I said in the last sentence of comment #1, it's not too much of a problem as we only include the version numbers that match release (e.g. "20.0") and that already excludes all the nightly-* for example as they have e.g. "20.0a1" anyhow. But for correctness, changing to a starts-with match is probably better, yes.
Pull request: https://github.com/mozilla/socorro/pull/1243

I do not know how to QA this. It would probably be enough to simply verify that search doesn't break and still shows coherent results (comparing to prod for example).
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/2dc2dd6206bfd0e4c3cd2ef2aec9dea242d79b4a
Fixes bug 864752 - Excluded channels now begin with the value in configuration.

https://github.com/mozilla/socorro/commit/0754b398d9034414a4e79aa2ca692e1588ccc2eb
Merge pull request #1243 from AdrianGaudebert/864752-excluded-channels-start-with

Fixes bug 864752 - Excluded channels now begin with the value in configu...
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 47
Product: Socorro → Socorro Graveyard
You need to log in before you can comment on or make changes to this bug.