864899 - PeerConnectionImpl.cpp:369:1: warning: ‘void sipcc::Warn(JSContext*, const nsCString&)’ defined but not used [-Wunused-function]

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

GCC 4.8 build warning in mozilla-central:
{
media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:369:1: warning: ‘void sipcc::Warn(JSContext*, const nsCString&)’ defined but not used [-Wunused-function]
}

The last usages of this function were removed in bug 855769's cset:
 https://hg.mozilla.org/mozilla-central/rev/915ad1e8a9bb#l3.22

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: remove function

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 740946 [details] [diff] [review]
fix: remove function

Review of attachment 740946 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Thanks!

Comment 3

[Daniel Holbert [:dholbert]]

[I assume that indicates an r+?  The flag is still set at "?", currently.]

Thanks!

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Yes sorry. :-)

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c7e9f21c920

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c7e9f21c920