Closed
Bug 865175
Opened 11 years ago
Closed 11 years ago
Fix communications import tests
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: basiclines, Assigned: basiclines)
References
Details
Attachments
(2 files)
A couple of test were failing since https://github.com/mozilla-b2g/gaia/commit/574ea2af224bb2a389f33de84f848227cbc3cc5c landed. There is another bug opened (and fixed) to comment these test to avoid Travis to fail: https://bugzilla.mozilla.org/show_bug.cgi?id=86271
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #741248 -
Flags: review?(jmcf)
Updated•11 years ago
|
Attachment #741248 -
Flags: review?(jmcf) → review+
Comment 2•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/b50bc0e6324c09bd8f45b7b05559d23291979639
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 3•11 years ago
|
||
sadly, while fixing the tests, this introduced a lint error. Could you please fix it ? Line 90, E:0002: Missing space after ","
Assignee | ||
Comment 4•11 years ago
|
||
Sure, also this fix breaks one test running alone. I'll fix both issues
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #742242 -
Flags: review?(jmcf)
Updated•11 years ago
|
Attachment #742242 -
Flags: review?(jmcf) → review+
Comment 6•11 years ago
|
||
Commit which fixes contacts_details_test https://github.com/mozilla-b2g/gaia/commit/e0f0729b2d749b92c88a1307c396d4faa11f16e7
Comment 7•11 years ago
|
||
Is this already fixed?
Comment 8•11 years ago
|
||
I think so. (at least the reported problem) We have other problems now but that's related to bug 867421...
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•