Closed Bug 865175 Opened 11 years ago Closed 11 years ago

Fix communications import tests

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: basiclines, Assigned: basiclines)

References

Details

Attachments

(2 files)

A couple of test were failing since https://github.com/mozilla-b2g/gaia/commit/574ea2af224bb2a389f33de84f848227cbc3cc5c landed.
There is another bug opened (and fixed) to comment these test to avoid Travis to fail: https://bugzilla.mozilla.org/show_bug.cgi?id=86271
Attached file PR
Attachment #741248 - Flags: review?(jmcf)
Attachment #741248 - Flags: review?(jmcf) → review+
https://github.com/mozilla-b2g/gaia/commit/b50bc0e6324c09bd8f45b7b05559d23291979639
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
sadly, while fixing the tests, this introduced a lint error. Could you please fix it ?

Line 90, E:0002: Missing space after ","
Sure, also this fix breaks one test running alone. I'll fix both issues
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file contact_details PR
Attachment #742242 - Flags: review?(jmcf)
Attachment #742242 - Flags: review?(jmcf) → review+
Is this already fixed?
I think so.

(at least the reported problem)

We have other problems now but that's related to bug 867421...
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: