Closed
Bug 865216
Opened 11 years ago
Closed 11 years ago
Recognize exacutables on WINNT in is_executable.
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(3 files)
|
1.45 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
|
27.38 KB,
text/plain
|
Details | |
|
439 bytes,
patch
|
Details | Diff | Splinter Review |
This fixes exacutable stripping on mingw build.
Attachment #741295 -
Flags: review?(mh+mozilla)
|
||
Updated•11 years ago
|
Attachment #741295 -
Flags: review?(mh+mozilla) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
Thanks for quick review. https://hg.mozilla.org/integration/mozilla-inbound/rev/c9f50b631b7d
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c9f50b631b7d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
when i ran "$pymake installers" in the objdir, I got errors. when I bakout this patch, it can pass. any idea?
|
|
Assignee | |
Comment 5•11 years ago
|
||
Does the attached patch help?
(In reply to Jacek Caban from comment #5) > Created attachment 742317 [details] [diff] [review] > patch > > Does the attached patch help? no. same error
|
|
Assignee | |
Comment 7•11 years ago
|
||
I don't see how this could happen on MSVC build. PKG_SKIP_STRIP should always be set there (configure script sets it unconditionally for MSVC builds), so may_strip should return false and strip() should never be called. Could you verify that your autoconf.mk has PKG_SKIP_STRIP set?
Sorry for the bother. the "--enable-install-strip" are not commented out in my mozconfig file.
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•