865355 - [MMS] Switch mozSms with mozMobileMessage

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Corey Frang [:gnarf]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.65 Safari/537.31

Steps to reproduce:

The mozMobileMessage interface will be used in favor of mozSms.  We should switch all the references in the gaia SMS app.

Comment 1

[Corey Frang [:gnarf]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/9388

Comment 2

[Julien Wajsberg [:julienw]]

blocking leo+ work -> leo+

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 741416 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9388

r=me except the sms_mock that was added to thread_ui_test.js.

I'll go ahead and remove it and merge this.

Comment 4

[Julien Wajsberg [:julienw]]

master: 20e4b6dd1c18eb0a3b3a37f6b2fb6b5bdb6aec51

Comment 5

[Julien Wajsberg [:julienw]]

note to triagers: this blocks all other mms work.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  20e4b6dd1c18eb0a3b3a37f6b2fb6b5bdb6aec51
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 7

[Julien Wajsberg [:julienw]]

conflicts caused by Bug 844900.

I asked approval there.

Comment 8

[Gene Lian (I already quit Mozilla)]

Just a info: we had a plan to use replace mozMobileMessage.send(...) with mozMobileMessage.sendSMS(...) at bug 85700 but not yet done.

Comment 9

[Gene Lian (I already quit Mozilla)]

(In reply to Gene Lian [:gene] from comment #8)
> Just a info: we had a plan to use replace mozMobileMessage.send(...) with
> mozMobileMessage.sendSMS(...) at bug 85700 but not yet done.
                                   ^^^^^^^^^ bug 857005, sorry.

Comment 10

[Julien Wajsberg [:julienw]]

v1-train: 5991a8a808b99ca26148f20532edfad6a54deaff