Closed
Bug 865715
Opened 11 years ago
Closed 11 years ago
warning in nsGUIEventIPC.h: potential use of uninitialized variable
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(1 file)
|
1.56 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 842927 (pt 1) introduced a compile warning in nsGUIEventIPC.h, in the ParamTraits<nsKeyEvent>::Read() method. If the first ReadParam() call ever returns false, the subsequent ones will not be executed, and so keyNameIndex will still be uninitialized when it is used to set the mKeyNameIndex field. Suggested fix is to simply avoid using keyNameIndex unless the ReadParam() calls all succeeded.
Attachment #741888 -
Flags: review?(bugs)
|
||
Updated•11 years ago
|
Attachment #741888 -
Flags: review?(bugs) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a62fb95a40b
Target Milestone: --- → mozilla23
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6a62fb95a40b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•