Closed
Bug 865766
Opened 11 years ago
Closed 11 years ago
GCC init list ordering build warning for MessageLoop in message_loop.cc
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.27 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
Build warning: { In file included from /mozilla-central/ipc/chromium/src/base/message_loop.cc:5:0: /mozilla-central/ipc/chromium/src/base/message_loop.h: In constructor 'MessageLoop::MessageLoop(MessageLoop::Type)': /mozilla-central/ipc/chromium/src/base/message_loop.h:424:7: warning: 'MessageLoop::next_sequence_num_' will be initialized after [-Wreorder] int next_sequence_num_; ^ In file included from /mozilla-central/ipc/chromium/src/base/message_loop.cc:5:0: /mozilla-central/ipc/chromium/src/base/message_loop.h:380:11: warning: 'PRInt32 MessageLoop::id_' [-Wreorder] PRInt32 id_; ^ /mozilla-central/ipc/chromium/src/base/message_loop.cc:91:1: warning: when initialized here [-Wreorder] MessageLoop::MessageLoop(Type type) ^ } The "id_" member-var was added in this cset for bug 857152: http://hg.mozilla.org/mozilla-central/rev/c97f19dc7f7f but it was put into the wrong place in the init list. Patch coming up.
Assignee | ||
Comment 1•11 years ago
|
||
id_ is declared immediately after type_, as shown here: > 379 Type type_; > 380 PRInt32 id_; http://mxr.mozilla.org/mozilla-central/source/ipc/chromium/src/base/message_loop.h#379 This patch reorders the init list to initialize it after type_, to match.
Attachment #741931 -
Flags: review?(justin.lebar+bug)
Updated•11 years ago
|
Attachment #741931 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/06927647efd7
Flags: in-testsuite-
Keywords: checkin-needed
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/06927647efd7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•