Closed
Bug 865901
Opened 11 years ago
Closed 11 years ago
make nsSVGTextFrame2::mPositioningDirty and mPositioningUsesPercentages SVG frame state bits
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: heycam, Assigned: longsonr)
Details
Attachments
(1 file)
|
13.20 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
We could save a bit of space by moving mPositioningDirty into the frame state bitfield.
|
||
Updated•11 years ago
|
Summary: make nsSVGTextFrame2::mPositioningDirty an SVG frame state bit → make nsSVGTextFrame2::mPositioningDirty and mPositioningUsesPercentages SVG frame state bits
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → longsonr
Attachment #766395 -
Flags: review?(cam)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 766395 [details] [diff] [review] patch r=me if you * name it NS_STATE_SVG_POSITIONING_MAY_USE_PERCENTAGES * preserve the documentation I added for mPositioningDirty and mPositioningMayUsePercentages somewhere (either above the #defines, or maybe somewhere in nsSVGTextFrame2.h still)
Attachment #766395 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=6c895fabb307
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=c39434ab0d5f https://hg.mozilla.org/integration/mozilla-inbound/rev/d53ba2cc5337
Flags: in-testsuite-
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d53ba2cc5337
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•