865958 - text in a <clipPath> does not reflow when changed

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: test

See the attached test.  This is broken with both the old and new text frames.

Comment 1

[Robert Longson [:longsonr]]

Attachment: fix old text frames

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 742784 [details] [diff] [review]
fix old text frames

I assume it's not problematic that this will update the glyph metrics if both NS_STATE_SVG_NONDISPLAY_CHILD and NS_FRAME_FIRST_REFLOW are set.

Comment 3

[Robert Longson [:longsonr]]

If NS_STATE_SVG_NONDISPLAY_CHILD is set then NS_FRAME_FIRST_REFLOW is never cleared as the frames never get an InitialUpdate call which is what clears it.

Comment 4

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=9d99a4fedebe

Comment 5

[Cameron McCormack (:heycam)]

(In reply to Robert Longson from comment #3)
> If NS_STATE_SVG_NONDISPLAY_CHILD is set then NS_FRAME_FIRST_REFLOW is never
> cleared as the frames never get an InitialUpdate call which is what clears
> it.

Makes sense, though it must be something like that.

Comment 6

[Cameron McCormack (:heycam)]

*thought

Comment 7

[Jonathan Watt [:jwatt]]

Comment on attachment 742784 [details] [diff] [review]
fix old text frames

>+  if ((GetStateBits() & (NS_STATE_SVG_NONDISPLAY_CHILD | NS_FRAME_FIRST_REFLOW)) != 
>+      NS_FRAME_FIRST_REFLOW) {

Can you maybe write that as the following?

  if (!(GetStateBits() & NS_FRAME_FIRST_REFLOW) ||
      (GetStateBits() & NS_STATE_SVG_NONDISPLAY_CHILD)) {

I think that makes it easier to grasp what this logic is doing. (And since GetStateBits() is inline there's negligible extra overhead in doing it that way.)

Comment 8

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9af815f4a9f

Comment 9

[Robert Longson [:longsonr]]

Marking [leave open] assuming a new text frame solution is required.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c9af815f4a9f

Comment 11

[Robert Longson [:longsonr]]

Cameron, are you planning to do anything for new text frames here? If not we should mark this as fixed.

Comment 12

[Cameron McCormack (:heycam)]

This is working again in the new text world.