Closed
Bug 866239
Opened 11 years ago
Closed 11 years ago
build broken on platforms without SPS
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: jbeich, Assigned: gaston)
References
Details
Attachments
(1 file)
3.37 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
In file included from dom/plugins/ipc/PluginModuleParent.cpp:24: In file included from dist/include/mozilla/plugins/PluginModuleParent.h:24: In file included from dist/include/mozilla/plugins/PluginInstanceParent.h:10: In file included from ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstanceParent.h:9: In file included from ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginInstance.h:22: dist/include/IPC/nsGUIEventIPC.h:267:10: warning: variable 'keyNameIndex' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] rv = ReadParam(aMsg, aIter, static_cast<nsInputEvent*>(aResult)) && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ dist/include/IPC/nsGUIEventIPC.h:274:50: note: uninitialized use occurs here static_cast<mozilla::widget::KeyNameIndex>(keyNameIndex); ^~~~~~~~~~~~ dist/include/IPC/nsGUIEventIPC.h:267:10: note: remove the '&&' if its condition is always true rv = ReadParam(aMsg, aIter, static_cast<nsInputEvent*>(aResult)) && ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ dist/include/IPC/nsGUIEventIPC.h:266:26: note: initialize the variable 'keyNameIndex' to silence this warning uint32_t keyNameIndex; ^ = 0 dom/plugins/ipc/PluginModuleParent.cpp:41:10: fatal error: 'nsIProfileSaveEvent.h' file not found #include "nsIProfileSaveEvent.h" ^ 1 warning and 1 error generated. gmake[1]: *** [PluginModuleParent.o] Error 1
Assignee | ||
Comment 1•11 years ago
|
||
Same failure on my buildbot : /var/buildslave-mozilla/mozilla-central-amd64/build/dom/plugins/ipc/PluginModuleParent.cpp:41:10: fatal error: 'nsIProfileSaveEvent.h' file not found #include "nsIProfileSaveEvent.h" Testing the obvious +#ifdef MOZ_ENABLE_PROFILER_SPS #include "nsIProfileSaveEvent.h" +#endif seems to fix the build here - i'll confirm in an hour or so if libxul links, and then post for review.
Assignee | ||
Comment 2•11 years ago
|
||
Spoke too fast: /src/mozilla-central/dom/plugins/ipc/PluginModuleParent.cpp:1744:14: error: use of undeclared identifier 'nsIProfileSaveEvent' nsCOMPtr<nsIProfileSaveEvent> pse = do_QueryInterface(aSubject); ^ /src/mozilla-central/dom/plugins/ipc/PluginModuleParent.cpp:1745:9: error: use of undeclared identifier 'pse' if (pse) { ^ /src/mozilla-central/dom/plugins/ipc/PluginModuleParent.cpp:1749:11: error: use of undeclared identifier 'pse' pse->AddSubProfile(result.get()); Guess all the new PluginModuleParent chunks added by c759d3eb1118 need to be within MOZ_ENABLE_PROFILER_SPS.. trying.
Assignee | ||
Comment 3•11 years ago
|
||
Seems to fix the build here - might be improvable.
Assignee: nobody → landry
Attachment #742699 -
Flags: review?(bgirard)
Comment 4•11 years ago
|
||
Comment on attachment 742699 [details] [diff] [review] Sprinkle some #ifdef MOZ_ENABLE_PROFILER_SPS Review of attachment 742699 [details] [diff] [review]: ----------------------------------------------------------------- Thank you! Not regressing disabling the profiler is important. Too bad we're not testing this on TBPL :(
Attachment #742699 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f60596a19c98
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f60596a19c98
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•