866278 - remote debugging protocol: number packets when dumping

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Jim Blandy :jimb]

Attachment: Remote debugging protocol: show sequence numbers with packets.

It makes packet logs a lot easier to read if you associate numbers with packets, and print when the packet is sent and received. For the simple tests, it's not interesting, but for the more involved tests, it's extremely helpful to be able to see when something was sent, and when it was actually received.

Comment 1

[Jim Blandy :jimb]

Attachment: Remote debugging protocol: show sequence numbers with packets.

Revised. Works better when the count is shared between the two paired LocalDebuggerTransport instances...

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 742579 [details] [diff] [review]
Remote debugging protocol: show sequence numbers with packets.

Review of attachment 742579 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/debugger/dbg-transport.js
@@ +262,4 @@
>     * endpoint.
>     */
>    send: function LDT_send(aPacket) {
> +    let serial = this.serial.count++;

Wouldn't it make sense to move this inside the if(wantLogging) branch?

Comment 3

[Jim Blandy :jimb]

(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 742579 [details] [diff] [review]
> Remote debugging protocol: show sequence numbers with packets.
> 
> Review of attachment 742579 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/devtools/debugger/dbg-transport.js
> @@ +262,4 @@
> >     * endpoint.
> >     */
> >    send: function LDT_send(aPacket) {
> > +    let serial = this.serial.count++;
> 
> Wouldn't it make sense to move this inside the if(wantLogging) branch?

I thought about that. But if something turns wantLogging on or off in the midst of a session, we could have packets sent before the switch being delivered after the switch, and it seemed like it would be more comprehensible to have them all numbered.

Comment 4

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e245f0728bc9

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e245f0728bc9