Closed
Bug 866412
Opened 11 years ago
Closed 11 years ago
Build failure: cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 23.0
People
(Reporter: ssitter, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
6.34 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
After applying the bustage fix from Bug 864256 I ran into the following problem: > .../mailnews/base/src/nsMsgFolderDataSource.cpp(186) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(187) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(188) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(189) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(190) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(191) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(192) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(193) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(194) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(195) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(196) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(197) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgFolderDataSource.cpp(198) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgAccountManagerDS.cpp(164) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsStatusBarBiffManager.cpp(58) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgDBView.cpp(152) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' > .../mailnews/base/src/nsMsgDBView.cpp(153) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *' Probably caused by the check-in for Bug 859817 (Make NS_NewAtom return already_AddRefed).
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #742710 -
Flags: review?(mbanner)
Comment 2•11 years ago
|
||
Comment on attachment 742710 [details] [diff] [review] Patch v1 Review of attachment 742710 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks.
Attachment #742710 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/271b24c7b667
Assignee: nobody → Ms2ger
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 859817
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → Thunderbird 23.0
Assignee | ||
Comment 4•11 years ago
|
||
And one more missed caller: https://hg.mozilla.org/comm-central/rev/3d3e10b5c289
You need to log in
before you can comment on or make changes to this bug.
Description
•