Closed Bug 866412 Opened 11 years ago Closed 11 years ago

Build failure: cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 23.0

People

(Reporter: ssitter, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

After applying the bustage fix from Bug 864256 I ran into the following problem:

> .../mailnews/base/src/nsMsgFolderDataSource.cpp(186) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(187) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(188) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(189) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(190) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(191) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(192) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(193) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(194) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(195) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(196) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(197) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgFolderDataSource.cpp(198) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgAccountManagerDS.cpp(164) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsStatusBarBiffManager.cpp(58) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgDBView.cpp(152) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'
> .../mailnews/base/src/nsMsgDBView.cpp(153) : error C2440: '=' : cannot convert from 'already_AddRefed<T>' to 'nsIAtom *'

Probably caused by the check-in for Bug 859817 (Make NS_NewAtom return already_AddRefed).
Attached patch Patch v1Splinter Review
Attachment #742710 - Flags: review?(mbanner)
Comment on attachment 742710 [details] [diff] [review]
Patch v1

Review of attachment 742710 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks.
Attachment #742710 - Flags: review?(mbanner) → review+
https://hg.mozilla.org/comm-central/rev/271b24c7b667
Assignee: nobody → Ms2ger
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 859817
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: