Closed Bug 866487 Opened 11 years ago Closed 11 years ago

MOZ_UPDATER always set to true in AppConstants.java

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: daichen314, Assigned: daichen314)

References

Details

Attachments

(1 file)

patch for bug866487
769 bytes, patch
snorp
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.20 (KHTML, like Gecko) Chrome/25.0.1337.0 Safari/537.20

Steps to reproduce:

set MOZ_UPDATER= in mobile/android/branding/unofficial/configure.sh


Actual results:

MOZ_UPDATER set to true in AppConstants.java


Expected results:

MOZ_UPDATER set to false in AppConstants.java

it should add ifdef XXX in android/base/Makefile.in before "-DMOZ_UPDATER=$(MOZ_UPDATER)"
Hi Chen, since you already found the cause of the issue, would you like to contribute a patch to fix it?
Blocks: 786380
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → Android
Hardware: x86 → ARM
I made a patch for android
Attachment #744100 - Attachment is patch: true
Attachment #744100 - Flags: review?(snorp)
Attachment #744100 - Flags: review?(snorp) → review+
Assignee: nobody → daichen314
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4c4810ef2092
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: