866685 - [Cost Control] Localization error for "Reset report Button" in Phone and Internet data report.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Leo]

1. Title : Localization error for "Reset report Button" in Phone and Internet data report.
2. Precondition : In FTE select the language other than English(US) and go to Settings - Language - Change the Language to English(US)
3. Tester's Action : Usage - Settings - Phone and Internet data report - Reset report
4. Detailed Symptom (ENG.) :The label on the Reset report button is not updated to English language.
6.Reproducibility: Y
1)Frequency Rate : 100%\
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 142dda6dfe500479c8cfba2bdcd3244b70434ea9
9.Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Screenshot attached

Comment 2

[Leo]

For "No SIM" case the alert is shown is wrong.Language is not updated properly.
The alert is shown as below in costcontrol app for no sim case. 
"widget-no-sim2-heading
widget-no-sim2-meta"

Comment 3

[Salvador de la Puente González [:salva]]

Hello!

There are to errors here. Please, let them be separated as this one:

> For "No SIM" case the alert is shown is wrong.Language is not updated
> properly.
> The alert is shown as below in costcontrol app for no sim case. 
> "widget-no-sim2-heading
> widget-no-sim2-meta"

is a duplicated for bug 863778.

Let me see the other.

Comment 4

[Leo]

(In reply to Leo from comment #0)
> 1. Title : Localization error for "Reset report Button" in Phone and
> Internet data report.
> 2. Precondition : In FTU(First Time User exp) select the language other than English(US) and go
> to Settings - Language - Change the Language to English(US)
> 3. Tester's Action : Usage - Settings - Phone and Internet data report -
> Reset report
> 4. Detailed Symptom (ENG.) :The label on the Reset report button is not
> updated to English language.
> 6.Reproducibility: Y
> 1)Frequency Rate : 100%\
> 7.Gaia Master/v1-train : Reproduced
> 8.Gaia Revision: 142dda6dfe500479c8cfba2bdcd3244b70434ea9
> 9.Personal email id: [e-mail]

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking, not blocking.

Comment 6

[Leo]

Attachment: Pointer to pull request : https://github.com/mozilla-b2g/gaia/pull/9930

Please review the patch.

Comment 7

[Salvador de la Puente González [:salva]]

Comment on attachment 752686 [details]
Pointer to pull request : https://github.com/mozilla-b2g/gaia/pull/9930

Please, check comments on GitHub, fix and renominate for review.

Thank you!

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 752686 [details]
Pointer to pull request : https://github.com/mozilla-b2g/gaia/pull/9930

You have a little indentation problem. Please, solve it before merging.
Thank you for your smart solution!

Comment 9

[Leo]

Indentation problem solved.Squashing is done.
Please review.

Comment 10

[Salvador de la Puente González [:salva]]

master: 8abc8d77776dae8c9f9f23a1494008e2ba4297b4

Comment 11

[Salvador de la Puente González [:salva]]

Comment on attachment 752686 [details]
Pointer to pull request : https://github.com/mozilla-b2g/gaia/pull/9930

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 841439
User impact if declined: medium (some words in other language)
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 12

[Leo]

Please uplift to V1train.

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8abc8d77776dae8c9f9f23a1494008e2ba4297b4 to:
v1-train: 87ba02ceaa3bc2648f70df2321cfb6b809acc0d9