867242 - Tab counter alignment issue on Nexus 7

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: screenshot

Looks like our number needs to move down 1 or 2 dp on the Nexus 7.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Fix tab counter alignment on tablets

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 744185 [details] [diff] [review]
Fix tab counter alignment on tablets

Does this affect phones too?

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 744185 [details] [diff] [review]
> Fix tab counter alignment on tablets
> 
> Does this affect phones too?

Nice catch, I'll have to find a way to only apply this change on tablets.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

Is this still an issue. If it is is there a reason this has not landed?

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to Kevin Brosnan [:kbrosnan] from comment #5)
> Is this still an issue. If it is is there a reason this has not landed?

My patch needs work as it causes a regression on the phone UI.

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

Carrying over tracking fennec request from duped bug.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.