Closed Bug 867764 Opened 11 years ago Closed 11 years ago

[bedrock] L10n of new newsletter/existing page on bedrock

Categories

(www.mozilla.org :: L10N, defect, P2)

Product:
www.mozilla.org
Component:
L10N
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jdavis, Assigned: malexis)

References

(
URL
)

Details

(Whiteboard: [kb=1093696] r=120063) 

Once Bug 841056 is launched, there will be new strings that will need to be localized so that we can launch the l10n versions of the Email Preference Center.

Bug 841056 is not only a port to bedrock, but also fixes a lot of bugs currently on production. It will be ideal to move quickly to get the l10n email preference centers working nicely.

There is no action to be taken at this time as we're finalizing thee bedrock port and content - but the launch could be next week and then it's go time. :)

Let me know if you have any questions/problems/conerns/etc.

Thanks!

Jess
Does it mean that there will be translation needs from localizers in May? Note that I will be on PTO for 2 weeks mid May.
Correct. Localization could need to start as soon as May 6th (Monday).

Are there people who can get localizations happening and push the strings live while you're out on PTO?
Milos might and maybe Brian king could help too, but I am not sure people in my team will have cycles to work on non firefoxOS stuff while I am on PTO.
Hey team, Just wanted to give a heads up that these updates should go live tomorrow/this week in en-US.

If possible, it'd be great to have these new bedrock pages localized and live by June 17th.

Let me know if you have any questions and I'll let you know as soon as everything is live in en-US.

Thanks!
No longer depends on: 841056
en-US/existing/newsletter is live!

Now time to localize and get the other locales live.


Pascal - do you think it'd be possible to get this localized and live by June 17th?
Blocks: 841056
Blocks: 851112
(In reply to Jessilyn Davis from comment #5)
> en-US/existing/newsletter is live!
> 
> Now time to localize and get the other locales live.
> 
> 
> Pascal - do you think it'd be possible to get this localized and live by
> June 17th?

This is unlikely, I can't work on that this week and probably not before end of next week, end of the month / early July is more likely.
Hi Pascal-

I realize that this is a super late request for the L10N team.

Unfortunately, we really need this live for June 17.

Is it at all possible to get the work done by then?  Could we reach out to Milos and Brian King like we did for the screenshots?

Thx,
Jen
Priority: -- → P1
Hi Pascal-

We have a work around for this - we'll make updates to the PHP pages instead of localizing the new page.

This is lower priority than other mozilla.org Fx OS L10N work.

Thx,
Jen
Priority: P1 → P4
Good, actually I started lookin the bedrock side and found a couple of bugs that affect strings, I'll make PRs soon but I can only work on that in between other projects.
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/dd4fac682b33964a71f3358fda2dcba964024848
Bug 867764 : fix broken link (html tag close sign is into the l10n string)
If l10n can't happen by June 28 (and it is absolutely a P4 and lower priority than FxOS l10n work) - Bug 882981 needs to happen.
Locales needed:

FR, DE, ES, PT-BR, RU, ID, PL
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/8fdb612e3dfb02140ea4ed237b157383979618ab
Bug 867764 fix a string not enclosed in an l10n call

https://github.com/mozilla/bedrock/commit/a08930c7a6b57c9f8d6b6285d64853f77d377265
Merge pull request #1135 from pascalchevrel/Bug_867764_newsletter_L10n_fixes

Bug 867764 fix a string not enclosed in an l10n call
Pascal, any updates on these translations?

It looks like all the bedrock work is done.
Flod, do you have any status update here?
Assignee: nobody → malexis
Flags: needinfo?(francesco.lodolo)
Priority: P4 → P2
Whiteboard: [kb=1093696]
TBH I don't have any update because I didn't follow the evolution of this bug and newsletter is not a part I've worked on so far.

I'll try to look into this before Pascal is back but can't make any promises considering the amount of work in progress right now.
Flags: needinfo?(francesco.lodolo)
I did a quick check and Pascal already added several strings to newsletter.lang. 

There are only 4 strings missing from other templates

# newsletter/base.html
;Newsletter Subscriptions
Newsletter Subscriptions

# newsletter/confirm.html
;Newsletter confirm
Newsletter confirm

# newsletter/existing.html
;Format:
Format:

# newsletter/hacks.mozilla.org.html
;Subscribe to our newsletter.
Subscribe to our newsletter.

While there are 14 from updated.html (almost the entire file). 
Do we need these strings too?
Thanks flod!  Answers inline. Let me know how quickly we can get these missing strings localized and the pages pushed live.

Thanks!

(In reply to Francesco Lodolo [:flod] from comment #17)

> There are only 4 strings missing from other templates
> 
> # newsletter/base.html
> ;Newsletter Subscriptions
> Newsletter Subscriptions

We need.

> 
> # newsletter/confirm.html
> ;Newsletter confirm
> Newsletter confirm

Would be nice to have - will need eventually.

> 
> # newsletter/existing.html
> ;Format:
> Format:

Definitely need.

> 
> # newsletter/hacks.mozilla.org.html
> ;Subscribe to our newsletter.
> Subscribe to our newsletter.

Do not need -  hacks.mozilla.org is not localized.
>
What about updated.html?
https://github.com/mozilla/bedrock/blob/master/bedrock/newsletter/templates/newsletter/updated.html

A few minutes after I wrote my comment a new template appeared (recovery.html), that should be just 2 or 3 strings (there's one not localizable right now on the button), but I guess that's needed as well?

It should not take much time, considering that all locales are complete except for pt-BR and id (missing 3 strings).
Flags: needinfo?(jdavis)
recovery.html does not need to be localized at this time. This page functionality (and the triggered email that's sent) is only in English at the moment. 

In Q4 we'll work on rolling out the l10n pages. I'll file a separate bug for this when the other l10n emails are ready.

Thanks!
Flags: needinfo?(jdavis)
Thanks Jessilyn, but I'm still missing the info about updated.html (which is the biggest one in terms of new strings). As soon as I have that I can send the new strings to localizers.
We will need updated.html too. That's the page that people see after submitting the /existing page.

Thanks!
New strings (17) pushed to localizers in r119471. I'll wait tomorrow and then send out an email to the list of locales you mentioned to see if I can speed things up.
Brilliant! Thanks flod!
Hi Flod! How's this coming along?

Also, is it possible to add 'hu' to the list of locales as well?

Thanks!
Strings have been added to all locales, right now we're still waiting for pt-BR and id (no answers to pings).
Thanks to Pascal's network we have all 7 locales completely translated (not sure if it matters, but all es-* are complete except for es-MX).
Excellent! Thank you Flod and Pascal!

If possible, can we use the es-ES strings for es-MX until es-MX is updated? That way our es-MX users can still see the info in Spanish, even if it isn't exactly their regional version - it's still better than defaulting to EN.
(In reply to Jessilyn Davis from comment #28)
> Excellent! Thank you Flod and Pascal!
> 
> If possible, can we use the es-ES strings for es-MX until es-MX is updated?
> That way our es-MX users can still see the info in Spanish, even if it isn't
> exactly their regional version - it's still better than defaulting to EN.

yes, no problem
Excellent! Pascal, can you confirm when es-MX's strings are good to go?

When it is ready, how do we test? Or do we just turn on bedrock for all the different locales on prod and the locales will magically happen?
Activated said locales for newsletter/existing/ in r120013.
Whiteboard: [kb=1093696] → [kb=1093696] r=120013
Merged activations to prod in r120017.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Looks good on: https://www.mozilla.org/b/de/newsletter/existing/cfa06343-b2e5-4c33-9132-b2b95b21166e/


Except for the title "Firefox & You" is not "Firefox & Du"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/4b215925eb3cfecd8adf7b157379df600607d6bf
Bug 867764 Translate newsletter names and descriptions

* On the /existing page, take the names and descriptions of the newsletters
  that come back from Basket and wrap them for translation before passing them
  to the template.  Some of these are translated already.
* Update the rewrite rule for /newsletter/existing to match all locales.

https://github.com/mozilla/bedrock/commit/ae79b28ba3931f0b984ef90c216bf4eb3b354705
Merge pull request #1238 from dpoirier/bug-867764-translate-newsletter-names

Bug 867764 Translate newsletter names and descriptions
Ready for test on -dev.  Try https://www-dev.allizom.org/de/newsletter/existing/cfa06343-b2e5-4c33-9132-b2b95b21166e/

Note that not all the newsletter descriptions have translations, and which ones do seems to vary by language. This change enables displaying the translated text where we have it. We'll need a separate task to arrange for the newsletter titles and descriptions to be translated regularly.
Thanks Dan!

The actual page looks good, but when I hit submit, I'm taken here to the old php page:
https://www-dev.allizom.org/de/newsletter/updated/

Can we get the /confirm page to be on bedrock and localized with this release - Bug 900156?  (It's weird to have a bedrock page, and the success go to a php page)
Can do. (I think you mean /updated.)  

One problem I noticed - we have "Thanks for updating your email preferences." translated, but the page is currently using "Thank you for updating your email preferences."

If we can change the updated page to say "Thanks for updating your email preferences." then it'll be translated, otherwise apparently it won't be yet.
Flags: needinfo?(jdavis)
Ah - thank you. Yes I meant /updated.

Please change it to "Thanks for updating your email preferences." so that we don't break the l10n strings.

Thanks!
Flags: needinfo?(jdavis)
Activated lang files for updated page in r120063.
Whiteboard: [kb=1093696] r=120013 → [kb=1093696] r=120063
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d1523687eec76a9e510385ff5395b6f8ead56837
Fix bug 867764 Finish moving /newsletter/updated to Bedrock

* Update rewrite rule to match all locales
* Tweak message to catch already-translated text
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Merged lang file changes to prod in r120066.
\o/
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.