Closed Bug 86786 Opened 23 years ago Closed 20 years ago

Expanding a folder on the Personal Toolbar stays on top of all other windows

Categories

(SeaMonkey :: Bookmarks & History, defect, P3)

Product:
SeaMonkey
Component:
Bookmarks & History
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.1alpha

People

(Reporter: cplyon, Assigned: neil)

References

Details

Attachments

(1 file, 1 obsolete file)

New patch
656 bytes, patch
janv
: review+
alecf
: superreview+
Details | Diff | Splinter Review 
Using build 2001061905 on Win2K

Steps to Reproduce:
1. Create a folder on the Personal Toolbar
2. Right click on the folder and select "Expand"
3. Either minimize Mozilla or bring another window in front of it

Results:
The expanded folder will remain visible with Mozilla minimized, and stay on top 
of all other windows.
Similar case in bug 85199.
See also bug 86649, Personal toolbar bookmark folder context menu should not
contain Expand.
As of build 2001092803, I"m not seeing the Expand menu item for Personal 
Toolbar folders.  If someone can confirm, I think we can close this bug.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
WFM
Reopening
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
*** Bug 116775 has been marked as a duplicate of this bug. ***
*** Bug 116866 has been marked as a duplicate of this bug. ***
Attached patch Proposed patch (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 63806 [details] [diff] [review]
Proposed patch

r=db48x

        Attachment #63806 -
        Flags: review+

    
    

    
  
*** Bug 119528 has been marked as a duplicate of this bug. ***

    
    

    
  
-> 1.1 as there is a patch. 
Status: REOPENED → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.1

    
    

    
  
*** Bug 115480 has been marked as a duplicate of this bug. ***

    
    

    
  
Please note:
While the folder is "expanded" Mozilla does not repond to keyboard input.

Changing OS to all based on duplicates.

Adding patch keyword.
Keywords: patch
OS: Windows 2000 → All

    
  
Blocks: keydead

    
    

    
  
*** Bug 133100 has been marked as a duplicate of this bug. ***

    
    

    
  
I am seeing a very similar situation here.  Only, the way to reproduce it is to 
drag a link to the personal toolbar over 2 or more folders on the toolbar.  A 
couple of the folders will expand, one will close, but the other is left 
hanging open and won't go away just like when you right click and 
choose "expand" on a personal toolbar folder.

That bug 70812 is pretty insidious.  If there is a patch for this, please get 
it in before 1.0!!!  This could be *very* annoying.

Jake

    
    

    
  
Related problem. If I have multiple folders on Personal Toolbar, expanding more
than one thru Expand context menu will not close any of the previously expanded.
Each newly expanded folder becomes a top-level window on top of all the
previously expanded folders. Also, Mozilla wouldn't minimize.

Related, bug 113427 is about using a bookmark two levels down inside expanded
folder.

W2K SP2, Build ID 2002031104


    
    

    
  
*** Bug 163719 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 163721 has been marked as a duplicate of this bug. ***

    
  

        Attachment #63806 -
        Flags: superreview?(bzbarsky)

        Attachment #63806 -
        Flags: superreview?(bzbarsky) → superreview+

    
    

    
  
A patch to bug 113247 was just checked in which I hope will also fix this bug.

    
    

    
  
Looks fixed to me using 20021120 on winxp

    
    

    
  
Fix checked in as part of fix to 113247.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED

    
    

    
  
Bug 113427 ;)

    
    

    
  
This happens again with Build 2003040518 and Windows XP. Also see bug 83141.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
I'd also like to note this affects Linux Gecko/20030405 Phoenix/0.5 as well. If
Mozilla will be moving to that toolkit, make sure you don't just fix it in the old

    
    

    
  
it sucks that this is not fixed even in Netscape 7.1

Netscape = Mozilla + AOL Junk

    
    

    
  
Neil, why didn't your original fix take care of this permanently?

Why do we even have an "Expand" option in the context menu? What does that do
that clicking on the link in the personal toolbar doesn't do? Seems pretty strange.

See comment #16 for a related problem, which no separate bug was filed for.

This bug is not preventing keyboard input, so it does not block 70812.
Assignee: bugs → neil.parkwaycc.co.uk
No longer blocks: keydead
Status: REOPENED → NEW

    
    

    
  
Is this bug even still valid?  Bug 232649 says that Expand doesn't even work
anymore, and bug 243235 argues for the option's removal.  I agree with comment
26.  The choice's existance doesn't make any sense.  We don't have "follow this
link" as the first option for the context menu for an <a> tag, do we?


    
    

    
  
pch's bookmarks rewrite (bug 196756) broke this. Naughty pch!

    
    

    
  

      
      
      
      

        Attached patch
          
          
        New patch
        — 
          — Splinter Review
      

    


  

        Attachment #63806 -
        Attachment is obsolete: true

    
  

        Attachment #150535 -
        Flags: superreview?(alecf)

        Attachment #150535 -
        Flags: review?(varga)

    
    

    
  
Comment on attachment 150535 [details] [diff] [review]
New patch

huh. Ok, if that works...sr=alecf

        Attachment #150535 -
        Flags: superreview?(alecf) → superreview+

    
  

        Attachment #150535 -
        Flags: review?(varga) → review+

    
    

    
  
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago → 20 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: