867903 - Investigate optimizing Configuration.getDescriptors in the Web IDL binding generator

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

After the path in bug 861587, this is in fact an actual hotspot now.  Patch and numbers coming up once I do a bit more measurement.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So for the .BindingGen target from bug 861587, after the patch in that bug, I'm seeing us take about 9.2s all told (that includes the time to load the makefile, etc).

With the patch I'm about to attach, that falls to 7s.

About 2s of that is no-op build overhead for loading the makefile and such, so the actual time spent in codegen drops from about 7.2s to about 5s (split between BindingGen and GlobalGen).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Speed up getDescriptors and some other obvious slow points in codegen.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 744486 [details] [diff] [review]
Speed up getDescriptors and some other obvious slow points in codegen.

The remaining obvious win would be to do both BindingGen and GlobalGen from the same script....

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Speed up getDescriptors and some other obvious slow points in codegen.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59c279d93f8e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for PGO bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0871f59b1ad5

https://tbpl.mozilla.org/php/getParsedLog.php?id=22789385&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=22789466&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=22789791&tree=Mozilla-Inbound

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5784ad28aa83

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbde8ec3af53