868035 - Enable Mochitests for gUM on B2G

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Eric Rescorla (:ekr)]

Currently, the gUM mochitests (dom/media/tests/mochitest/test_getUserMedia_basicAudio.html etc) do not run on b2g. Once b2g gUM starts working, we should change that.

The task here is to enable them, test that they work in try, and then commit the enablement,
fixing as necessary.

The relevant line of code, for example is the true at:
https://hg.mozilla.org/mozilla-central/file/e474b6cfebce/dom/media/tests/mochitest/test_getUserMedia_basicAudio.html#l39

Which sets desktop only.

Comment 1

[Jason Smith [:jsmith]]

I'm changing something fundamental on how we control what tests run on what platform over in bug 862883. Let's wait for that to land first before implementing this.

Comment 2

[u459114]

S.C, please help on this issue

Comment 3

[Martijn Wargers (dead)]

See also bug 903765.

Comment 4

[Martijn Wargers (dead)]

Attachment: log.txt

Currently, the whole dom/media/tests/mochitest subdirectory is excluded in the b2g.json file.
I did a run of that directory, see log, there are a lot of failures, but at least some of the test files seem to be passing.
I could remove the dom/media/tests/mochitest subdirectory from the exclude list and add the test files from that subdirectory that are currently failing.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #4)
> Created attachment 793552 [details]
> log.txt
> 
> Currently, the whole dom/media/tests/mochitest subdirectory is excluded in
> the b2g.json file.
> I did a run of that directory, see log, there are a lot of failures, but at
> least some of the test files seem to be passing.
> I could remove the dom/media/tests/mochitest subdirectory from the exclude
> list and add the test files from that subdirectory that are currently
> failing.

The test run there indicates the gUM tests are passing right now actually. The PC/DC tests failing is expected and not surprising.

What we need to do here to fix this is just alter the b2g.json file to have the PC/DC tests turned off only.

Comment 6

[Martijn Wargers (dead)]

These tests are passing:
"dom/media/tests/mochitest/test_getUserMedia_exceptions.html":"",
"dom/media/tests/mochitest/test_getUserMedia_gumWithinGum.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playAudioTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playVideoAudioTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_playVideoTwice.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopAudioStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopAudioStreamWithFollowupAudio.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoAudioStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoAudioStreamWithFollowupVideoAudio.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoStream.html":"",
"dom/media/tests/mochitest/test_getUserMedia_stopVideoStreamWithFollowupVideo.html":"",
"dom/media/tests/mochitest/test_peerConnection_toJSON.html":""

Comment 7

[Martijn Wargers (dead)]

(In reply to Jason Smith [:jsmith] from comment #5)
> What we need to do here to fix this is just alter the b2g.json file to have
> the PC/DC tests turned off only.

Ok, I can do that.

Comment 8

[Martijn Wargers (dead)]

Attachment: 868035.diff

I'll test this on tryserver.

Comment 9

[Martijn Wargers (dead)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=516ec7ea0b8f

Comment 10

[Martijn Wargers (dead)]

Comment on attachment 793679 [details] [diff] [review]
868035.diff

Review of attachment 793679 [details] [diff] [review]:
-----------------------------------------------------------------

Tryserver passes
I did a rebuild of 15 times for chunk 4 (where these tests were exercised).

Comment 11

[Jonathan Griffin (:jgriffin)]

Comment on attachment 793679 [details] [diff] [review]
868035.diff

Review of attachment 793679 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good if the retriggers don't show any intermittents.

Comment 12

[Martijn Wargers (dead)]

Attachment: 868035.diff (for check-in)

All the 15 chunks where green, so seems intermittent fail-safe.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/be955e7ae7d5

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be955e7ae7d5

Comment 15

[Martijn Wargers (dead)]

(In reply to Jason Smith [:jsmith] from comment #5)
> The test run there indicates the gUM tests are passing right now actually.
> The PC/DC tests failing is expected and not surprising.

I filed bug 908473 for this, not sure if it is feasible to get these tests working on b2g.