868413 - Remove deprecated methods in Tabzilla.js (2013-08-01)

Status: VERIFIED FIXED

(Websites :: Tabzilla, defect, P3)

Description

[Isac Lagerblad (:icaaq)]

Tabzilla.js now includes some deprecated methods:

Tabzilla.opened();
Tabzilla.closed();

This bug is just a reminder to removes those methods around TOPIC date.

cc: :sgarrity

Comment 1

[raymond [:retornam] (inactive)]

(In reply to Isac Lagerblad (:icaaq) from comment #0)
> Tabzilla.js now includes some deprecated methods:
> 
> Tabzilla.opened();
> Tabzilla.closed();
> 
> This bug is just a reminder to removes those methods around TOPIC date.
> 
> cc: :sgarrity

Isac can we keep these so we could use them to toggle the dropdown when testing with selenium?

Comment 2

[Isac Lagerblad (:icaaq)]

(In reply to raymond [:retornam] from comment #1)
> (In reply to Isac Lagerblad (:icaaq) from comment #0)
> > Tabzilla.js now includes some deprecated methods:
> > 
> > Tabzilla.opened();
> > Tabzilla.closed();
> > 
> > This bug is just a reminder to removes those methods around TOPIC date.
> > 
> > cc: :sgarrity
> 
> Isac can we keep these so we could use them to toggle the dropdown when
> testing with selenium?

Could you please change the calls to Tabzilla.open() and Tabzilla.close() instead.

Comment 3

[raymond [:retornam] (inactive)]

I have updated the tests to use Tabzilla.open and Tabzilla.close and removed the deprecated methods in this pull request https://github.com/mozilla/bedrock/pull/854

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d8f173f08182e606784c95bcca1a24d6d0929c18
Bug 868413 remove deprecated methods from Tabzilla

https://github.com/mozilla/bedrock/commit/ece0e8ad98a0fa901d8284a95509472c1160255a
Merge pull request #854 from retornam/bug-868413-remove-tabzilla-methods

Bug 868413 remove deprecated methods from Tabzilla

Comment 5

[Steven Garrity [:sgarrity]]

Tests were updated, so we're going ahead and removing now.

Comment 6

[raymond [:retornam] (inactive)]

fixed on stage

Comment 7

[raymond [:retornam] (inactive)]

fixed on prod

Comment 8

[Kohei Yoshino [:kohei]]

Sorry for the bugspam -- the Target Milestore was set unexpectedly.