868516 - Add newrelic to login

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[JP Schneider :jp]

Lets go ahead and add newrelic to login. Once you do, I'll update the system config builds to include it!

Comment 1

[David Humphrey (:humph)]

See bug 864938 for how it was done in MakeAPI

Comment 2

[David Humphrey (:humph)]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/45

Comment 3

[Chris DeCairos (:cade)]

Comment on attachment 745272 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/45

Looks great!

Lets ensure we communicate to JP that the NEW_RELIC_ENABLED flag can now be set in his deploy scripts for login

R+

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/cf3f204834effd97cd4b981ffff339a7c988eff6
Fix bug 868516 - Add newrelic to login r=cade

Comment 5

[JP Schneider :jp]

I took the branch used for the pull request (https://github.com/mozilla/login.webmaker.org/pull/45 ) and built that as v0.0.4 from a forked repo.  The build worked A-OK (http://jenkins.mofoprod.net:8080/job/wmlogin/2/console)

I have reviewed the change, and it looks spot on to me.  Further, it works!  The app is up here:  https://rpm.newrelic.com/accounts/255689/applications/2760932


May  4 15:58:31 i-8ccc34e2 app=wmlogin-staging: 15:58:31 web.1  | info: HTTP server listening on port 80.
May  4 15:58:31 i-8ccc34e2 app=wmlogin-staging: 15:58:31 web.1  | {"name":"newrelic","hostname":"i-8ccc34e2","pid":17166,"component":"data_sender","level":30,"msg":"Reporting to: https://rpm.newrelic.com/accounts/255689/applications/2760932","time":"2013-05-04T15:58:31.244Z","v":0}
May  4 15:58:31 i-8ccc34e2 app=wmlogin-staging: 15:58:31 web.1  | {"name":"newrelic","hostname":"i-8ccc34e2","pid":17166,"component":"connection","level":30,"msg":"Connected to collector-5.newrelic.com:80 with agent run ID 548241717.","time":"2013-05-04T15:58:31.245Z","v":0}

Huzzah!  I'm going to go ahead and merge that pull request, tag that as v0.0.4.  I won't rebuild and push, since that debian is already out of the barn, but this way we keep versions in sync.

Nicely done folks, thank you!  I can now start load testing and looking at this app more effectively!

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/1409118cc977040170aa04c00136511a5b11ef56
Bug 868516 - Add newrelic to login

https://github.com/mozilla/login.webmaker.org/commit/6f395225ad42ab007a15357be5a180c987e657e2
Merge pull request #45 from humphd/bug868516

Bug 868516 - Add newrelic to login 
Notes for testing and validating this above.  cc @humphd @cade