868776 - Fix rooting hazards in Web Audio code

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[(no longer active)]

Attachment: Patch (v2)

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 745582 [details] [diff] [review]
Patch (v2)

Review of attachment 745582 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the return value checks added.

::: content/media/webaudio/AudioBuffer.cpp
@@ +99,5 @@
>        const float* data = mSharedChannels->GetData(i);
>        // The following code first zeroes the array and then copies our data
>        // into it. We could avoid this with additional JS APIs to construct
>        // an array (or ArrayBuffer) containing initial data.
> +      JS::RootedObject array(aJSContext, JS_NewFloat32Array(aJSContext, mLength));

Damn, missed this earlier. JS_NewFloat32Array can return NULL, so please check the result here, too.

@@ +137,5 @@
>  {
>    RestoreJSChannelData(aJSContext);
>  
>    MOZ_ASSERT(aChannel < NumberOfChannels());
> +  JS::RootedObject arrayBuffer(aJSContext, JS_NewArrayBufferWithContents(aJSContext, aContents));

And this, too.

@@ +142,1 @@
>    mJSChannels[aChannel] = JS_NewFloat32ArrayWithBuffer(aJSContext, arrayBuffer,

And this.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d7033aeb74

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e6d7033aeb74

Comment 6

[(no longer active)]

Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.