868819 - [suggestions] should highlight if one suggestion is exactly the same than the word currently typed, or if it starts with the currently typed word

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Julien Wajsberg [:julienw]]

So, I wrote a bunch of Sms with the suggestion feature enabled, and I feel like this improvement could be good.

When we type a word, if that word is exactly one of the suggestion, that suggestion should be highlighted (with no need to replace it when the user presses one of the "completion key").

Moreover, if exactly one suggestion starts with the currently typed word, it should be highlighted and selected if the user presses one of the "completion keys" (eg: space, etc).

Comment 1

[Julien Wajsberg [:julienw]]

need info David so that he knows about this bug.

Comment 2

[David Flanagan [:djf]]

Julien,

I've been talking with Francis about the UX of how this should work, and we'll be improving this.  Probably not exactly as you suggest, however.  I may open a new bug, or possibly use this one for those changes.

(In reply to Julien Wajsberg [:julienw] from comment #0)
> So, I wrote a bunch of Sms with the suggestion feature enabled, and I feel
> like this improvement could be good.
> 
> When we type a word, if that word is exactly one of the suggestion, that
> suggestion should be highlighted (with no need to replace it when the user
> presses one of the "completion key").

Most of the time I agree. I think I've not been highlighting words that are exact matches because they won't be auto-corrected, they'll just be accepted. Francis has convinced me that if the word you see after you press space should always be highlighted even if there is no change from what you've already typed.  So I'll be doing that.

But not always: if an (english-speaking) user types "ill", "ill" will be one of the suggestions, but "I'll" will be a much more highly weighted suggestion and in this case we will highlight I'll instead of ill.  (cant and wont are also legal English words, but users almost always want to auto-correct to can't and won't).

> Moreover, if exactly one suggestion starts with the currently typed word, it
> should be highlighted and selected if the user presses one of the
> "completion keys" (eg: space, etc).

Again, I agree that this is usually the right thing. But not always. If the user types "teh", I think we want to highlight "the" and not "Tehran"

Comment 3

[David Flanagan [:djf]]

Attachment: link to patch on github

This patch doesn't do exactly what Julien requested, but it does something like what UX requested, and it is a first step in the direction that the visual design team would like to go.

This is basically an experimental improvement to word suggestions and auto-correct. Chris Lee would like it to land soon so that he and others can try it out and decide whether to uplift auto-correct to v1.1.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 746816 [details]
link to patch on github

Good to go if the question (see the pull request) is fine.
 - When the input is exactly the 3rd suggestion.

Thanks.

Comment 5

[David Flanagan [:djf]]

Thanks for catching that Rudy!  Fixed.

Landed to Gaia master: https://github.com/mozilla-b2g/gaia/commit/9fa85e6ec186f865810a7ad1a4805fd37689c6d0

Comment 6

[Julien Wajsberg [:julienw]]

Thanks David, I'm perfectly happy with all your corrections to my proposition :)

Comment 8

[:CSchmoeckel]

The word in queue for the predictive text word suggestion is always highlighted. The highlighted word is typically the one manually entered by the user, unless an auto-correction has taken place. Feature is behaving as described in Comment 2. 
Tested on b2g/nightly/mozilla-central-unagi/latest.

Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/mozilla-central/rev/3c6f2394995d
Gaia: d2ad0f1a5a6be8a2d6df721ba3c2b33e037c423b

Comment 9

[Tony Chung [:tchung]]

Please add a testcase for this bug to moztrap for 1.1 testsuite.  If yes, mark this in-moztrap+ when completed.  If not, mark this in-moztrap-.

Comment 10

[David Flanagan [:djf]]

Uplifted to v1-train in bug 873934

Comment 11

[:CSchmoeckel]

Added Keyboard Suite Test Case #8500 - [Keyboard] Auto Correct highlights the word that is chosen using predictive text