869134 - currentset should return defaultset if it doesn't have a value, so add-ons don't reset the toolbar

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Bug 868820 and probably others are caused by incorrect manipulation of the button set in a toolbar before any other customizations have happened.

According to bug 868820 comment 5, the problem is that getting the currentset when no customizations have happened will get you a blank string. In those cases, one should ask for defaultset instead. However, if currentset were never blank, this problem would be avoided entirely. I don't know if there's a reason for this, but we should reconsider it, given that the incorrect usage of this property can lead to blank toolbars and lots of user confusion.

Comment 1

[Dão Gottwald [:dao]]

Toolbars' currentSet property returns a string containing all present elements even when no customization happened. People should use that.