869346 - [System] [Video] [Bluetooth] String message is half-hidden when Share->Bluetooth is selected on a video.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Leo]

1. Title : [System] [Video] [Bluetooth] String message is half-hidden when Share->Bluetooth is selected on a video.
2. Precondition : Run Video app and select a video. And select Share button.
3. Tester's Action : Rotate device and see the bluetooth confirmation dialog also rotates.
4. Detailed Symptom (ENG.) : The string message is half-hidden in the dialog.
5. Expected : Nothing should be hidden in part.
6.Reproducibility: Y
           1)Frequency Rate : 100%
7. Version: AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.075, Mozilla build ID: 20130425070204
8.Personal email id:  [e-mail]

Comment 1

[Leo]

Attachment: screenshot

Comment 2

[Leo]

The same observation has been seen in gallery app.

Comment 3

[Leo]

It seems that the manifest.webapp's orientation value is ignored when MozActivity is used.

For example, \apps\bluetooth\manifest.webapp has "orientation": "portrait-primary". However, when its 'share' activity is displayed, the orientation does not stay portrait.

Comment 4

[Leo]

Hi Alive, 

I'd like to ask for your comment on this. Thanks!

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Two ways to solve this:
1) Make the dialog scrollable.
2) Lock orientation when inline activity shows.
I think 1) is more suitable.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

c.c. Ian

Comment 8

[Leo]

(In reply to Alive Kuo [:alive] from comment #5)
> Two ways to solve this:
> 1) Make the dialog scrollable.
> 2) Lock orientation when inline activity shows.
> I think 1) is more suitable.

It seems this applies to all inline activities and 1) fix is limited to a specific dialog only. How about we do 2) and have it fixed in all inline activities?

Comment 9

[Leo]

Attachment: Power off option

I believe this is also the same issue. How about we have a general fix, which is 2)?

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

They are different things but lock orientation for both is acceptable, to me.

Comment 11

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9811

Pointer to Github pull-request

Comment 12

[[e-mail], [e-mail]]

Comment on attachment 750323 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9811

The base font size 13.3px makes the message truncated in landscape mode.
Remove media query for 480x800 phones. We don't support multi-resolution in v1-train.

Comment 13

[[e-mail], [e-mail]]

Gaia master contains https://github.com/mozilla-b2g/gaia/commit/6089f2f0a5698e77494881b58b2721d781c887fc for supporting multiple resolution. The issue won't be happened since it removed the based font size 13.3px.

Comment 14

[Leo]

(In reply to Ian Liu [:ianliu] from comment #13)
> Gaia master contains
> https://github.com/mozilla-b2g/gaia/commit/
> 6089f2f0a5698e77494881b58b2721d781c887fc for supporting multiple resolution.
> The issue won't be happened since it removed the based font size 13.3px.

Hi Ian, 

Your patch fixes only the bluetooth inline activity. Can we have a patch that fixes this issue in general?

This is not just a resolution issue. 

For example, this bluetooth inline activity's manifest.app has "orientation": "portrait-primary". However, it rotates!
(\b2g\gaia\apps\bluetooth\manifest.webapp)

Comment 15

[[e-mail], [e-mail]]

(In reply to Leo from comment #14)
> (In reply to Ian Liu [:ianliu] from comment #13)
> > Gaia master contains
> > https://github.com/mozilla-b2g/gaia/commit/
> > 6089f2f0a5698e77494881b58b2721d781c887fc for supporting multiple resolution.
> > The issue won't be happened since it removed the based font size 13.3px.
> 
> Hi Ian, 
> 
> Your patch fixes only the bluetooth inline activity. Can we have a patch
> that fixes this issue in general?
> 
> This is not just a resolution issue. 
> 
> For example, this bluetooth inline activity's manifest.app has
> "orientation": "portrait-primary". However, it rotates!
> (\b2g\gaia\apps\bluetooth\manifest.webapp)

In my opinion, I don't think it's a friendly way to lock orientation for inline activity page. We should keep current behavior here. If we really want to do so, it should reference the orientation in "activities" scoop. Could be..

  "activities": {
    "share": {
      "filters": {
      	"number": 1
       },
      "disposition": "inline",
      "returnValue": true,
      "href": "/transfer.html",
+     "orientation": "portrait-primary",
    }   
  }, 

And the parameter could be: "portrait-primary", "landscape-primary", "depend-requester"... We should create another issue for the new feature.

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Leo from comment #14)
> (In reply to Ian Liu [:ianliu] from comment #13)
> > Gaia master contains
> > https://github.com/mozilla-b2g/gaia/commit/
> > 6089f2f0a5698e77494881b58b2721d781c887fc for supporting multiple resolution.
> > The issue won't be happened since it removed the based font size 13.3px.
> 
> Hi Ian, 
> 
> Your patch fixes only the bluetooth inline activity. Can we have a patch
> that fixes this issue in general?
> 
> This is not just a resolution issue. 
> 
> For example, this bluetooth inline activity's manifest.app has
> "orientation": "portrait-primary". However, it rotates!
> (\b2g\gaia\apps\bluetooth\manifest.webapp)

We could open another bug for the orientation hell we have.
Exactly, any app/any activity/any window.opened page could lock orientation..without manifest.
And that may result lots of problems..because currenly it's not manipulated well.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 750323 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9811

r+ first since this is QE2 bug...

Comment 18

[[e-mail], [e-mail]]

Thanks for Alive's reviewing effort. Since the pr is merged, we can close the issue now.
https://github.com/mozilla-b2g/gaia/commit/991bb2d9a64df2e532ad92677248aec30076ee8b

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Ian Liu [:ianliu] from comment #18)
> Thanks for Alive's reviewing effort. Since the pr is merged, we can close
> the issue now.
> https://github.com/mozilla-b2g/gaia/commit/
> 991bb2d9a64df2e532ad92677248aec30076ee8b

This commit is on v1-train, so marking the branch status appropriately.

Is there anything that needs to be landed on master branch for this?

Comment 20

[[e-mail], [e-mail]]

Hi John,
Thanks for your reminder. It doesn't need to be landed on master because the removed code is not in master. It has been removed via supporting multiple resolution for a long time.