Closed
Bug 869497
Opened 11 years ago
Closed 11 years ago
Remove function expression names from the debugger, netmonitor and widgets
Categories
(DevTools :: General, defect, P3)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 24
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file)
291.68 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
REDUNDUNDANT.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P3
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #746584 -
Flags: review?(rcampbell)
Assignee | ||
Comment 2•11 years ago
|
||
Green: https://tbpl.mozilla.org/?tree=Try&rev=6dcc1c0f1ecc
Comment 3•11 years ago
|
||
Comment on attachment 746584 [details] [diff] [review] v1 Review of attachment 746584 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/debugger/CmdDebugger.jsm @@ +109,5 @@ > " <span class='gcli-out-shortcut'" + > " data-command='break del ${breakpoint.index}'" + > " onclick='${onclick}'" + > + " ondblclick='${ondblclick}'>" + > + " " + gcli.lookup("breaklistOutRemove") + "</span>" + character shuffling? @@ +144,3 @@ > let dbg = getPanel(context, "jsdebugger"); > if (dbg) { > + return dbg.panelWin.DebuggerView.Sources.values; ++ ::: browser/devtools/debugger/DebuggerUI.jsm @@ +173,5 @@ > * The parent instance creating the new debugger. > * @param XULElement aTab > * The tab in which to create the debugger. > */ > +this.DebuggerPane = function DebuggerPane(aDebuggerUI, aTab) { why bother with this? The previous is essentially the same, putting DebuggerPane on the local global context. @@ +304,5 @@ > * > * @param DebuggerUI aDebuggerUI > * The parent instance creating the new debugger. > */ > +this.RemoteDebuggerWindow = function RemoteDebuggerWindow(aDebuggerUI) { ditto. ::: browser/devtools/debugger/debugger-controller.js @@ +4,5 @@ > * License, v. 2.0. If a copy of the MPL was not distributed with this > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > "use strict"; > > +const { classes: Cc, interfaces: Ci, utils: Cu } = Components; this is what we've become.
Attachment #746584 -
Flags: review?(rcampbell) → review+
Comment 4•11 years ago
|
||
very well. let them all rebase.
Assignee | ||
Comment 5•11 years ago
|
||
Rebased (oh the irony) and landed: https://hg.mozilla.org/integration/fx-team/rev/c7a70d12c122
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c7a70d12c122
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•