869890 - thunderbird should declare itself dpiAware on windows via the .exe manifest

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Jonathan Kew [:jfkthame]]

In bug 866365, we removed the call to SetProcessDPIAware from XRE_mainInit(), and instead added the dpiAware element to firefox.exe's manifest. (This is the MS recommended way for an application to declare itself dpi-aware, as per MSDN documentation.)

So to maintain its existing behavior on hi-dpi windows systems, thunderbird should make the same manifest addition. Bug 866365 is likely to be uplifted to mozilla-22, I think, so that's also where the manifest change should be made.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: declare thunderbird.exe as dpi-aware in its manifest

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 746893 [details] [diff] [review]
declare thunderbird.exe as dpi-aware in its manifest

Not tested, but looks fine as a copy of what was landed for FF. r=Standard8.

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/comm-central/rev/f85134b411f6

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 746893 [details] [diff] [review]
declare thunderbird.exe as dpi-aware in its manifest

[Approval Request Comment]

See bug 866365 comment 46. The change there has just landed on Aurora, so the matching thunderbird change also needs to be uplifted.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 746893 [details] [diff] [review]
declare thunderbird.exe as dpi-aware in its manifest

[Triage Comment]
The core patch is on beta now, post merges, so we'll take this on beta as well.

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/e3ed50e2cc6d