Closed
Bug 869939
Opened 11 years ago
Closed 11 years ago
Migrate items out of the add-on bar to the nav-bar
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Keywords: addon-compat)
Attachments
(1 file, 1 obsolete file)
38.71 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Because the addon-bar is disappearing, items will need to be moved to the nav-bar so that they do not disappear from the UI entirely.
Assignee | ||
Comment 1•11 years ago
|
||
Seeing as to test whether this would work, I had to remove it, I went and did it properly...
Attachment #747348 -
Flags: review?(jaws)
Assignee | ||
Comment 2•11 years ago
|
||
Questions: 1) this doesn't work if you've already used jamun/ux and have a customization state stored in a pref. Setting the currentset has no effect because we don't remigrate it, as we already have an updated state stored in a pref. What would be the best workaround for this, or do we not care? 2) This works in my limited testing if you don't have a pref-stored customization state, but I'm not sure if we're dealing with the status-bar correctly. Also, we currently have a shim for the status-bar because removing it broke too much stuff for Fx4. This would definitely get rid of it (bug 598929). I'm not 100% clear how currentset on the toolbar deals with items nested in the status-bar; I'm assuming they'd be included? Or should I scrape items out of there, too?
Comment 3•11 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #2) > I'm not 100% clear how currentset on the toolbar deals with > items nested in the status-bar; I'm assuming they'd be included? No, they aren't. Add-ons always add items to the status-bar element autonomously, its state isn't stored anywhere.
Updated•11 years ago
|
Attachment #747348 -
Flags: review?(jaws) → review+
Updated•11 years ago
|
Keywords: addon-compat
Comment 5•11 years ago
|
||
We had already filed a bug to remove the add-on bar (bug 863042), but that work seems to be happening here now.
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 747349 [details] [diff] [review] Part 1, WIP: Migrate addonbar-addons to the nav-bar This has bitrotted because of bug 870545.
Attachment #747349 -
Attachment is obsolete: true
Assignee | ||
Comment 7•11 years ago
|
||
Per discussion on fx-dev, being bold and wontfixing this. We'll keep the addon bar (for now) and make it a customization target instead, for which I've just filed bug 872209.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•